diff options
author | Luigi Pinca <luigipinca@gmail.com> | 2018-02-16 15:46:48 +0100 |
---|---|---|
committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-02-17 15:22:14 +0100 |
commit | 33103e97587b3efa073d00752864210b43c5fc4a (patch) | |
tree | 39b9864650ac7597fcd7ece08d46917374ec601f /test/parallel/test-stream-writable-constructor-set-methods.js | |
parent | 81232320aa09a5ed5d4203e6b7ed708fd3f6e91b (diff) | |
download | android-node-v8-33103e97587b3efa073d00752864210b43c5fc4a.tar.gz android-node-v8-33103e97587b3efa073d00752864210b43c5fc4a.tar.bz2 android-node-v8-33103e97587b3efa073d00752864210b43c5fc4a.zip |
test: refactor stream-*-constructor-set-methods
- Use `common.mustCall()` to ensure that callbacks are called.
- Remove no longer needed variables.
- Remove unnecessary `process.on('exit')` usage.
PR-URL: https://github.com/nodejs/node/pull/18817
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'test/parallel/test-stream-writable-constructor-set-methods.js')
-rw-r--r-- | test/parallel/test-stream-writable-constructor-set-methods.js | 52 |
1 files changed, 22 insertions, 30 deletions
diff --git a/test/parallel/test-stream-writable-constructor-set-methods.js b/test/parallel/test-stream-writable-constructor-set-methods.js index 441e8ee75b..425cd88ed7 100644 --- a/test/parallel/test-stream-writable-constructor-set-methods.js +++ b/test/parallel/test-stream-writable-constructor-set-methods.js @@ -1,45 +1,37 @@ 'use strict'; const common = require('../common'); -const assert = require('assert'); -const Writable = require('stream').Writable; +const { strictEqual } = require('assert'); +const { Writable } = require('stream'); -let _writeCalled = false; -function _write(d, e, n) { - _writeCalled = true; -} +const _write = common.mustCall((chunk, _, next) => { + next(); +}); + +const _writev = common.mustCall((chunks, next) => { + strictEqual(chunks.length, 2); + next(); +}); -const w = new Writable({ write: _write }); -w.end(Buffer.from('blerg')); +const w = new Writable({ write: _write, writev: _writev }); -let _writevCalled = false; -let dLength = 0; -function _writev(d, n) { - dLength = d.length; - _writevCalled = true; -} +strictEqual(w._write, _write); +strictEqual(w._writev, _writev); -const w2 = new Writable({ writev: _writev }); -w2.cork(); +w.write(Buffer.from('blerg')); -w2.write(Buffer.from('blerg')); -w2.write(Buffer.from('blerg')); -w2.end(); +w.cork(); +w.write(Buffer.from('blerg')); +w.write(Buffer.from('blerg')); -const w3 = new Writable(); +w.end(); -w3.on('error', common.expectsError({ +const w2 = new Writable(); + +w2.on('error', common.expectsError({ type: Error, code: 'ERR_METHOD_NOT_IMPLEMENTED', message: 'The _write method is not implemented' })); -w3.end(Buffer.from('blerg')); - -process.on('exit', function() { - assert.strictEqual(w._write, _write); - assert(_writeCalled); - assert.strictEqual(w2._writev, _writev); - assert.strictEqual(dLength, 2); - assert(_writevCalled); -}); +w2.end(Buffer.from('blerg')); |