summaryrefslogtreecommitdiff
path: root/test/parallel/test-stream-transform-final.js
diff options
context:
space:
mode:
authorRishabh Singh <rishabhptr@gmail.com>2018-08-01 10:02:31 +0530
committerJon Moss <me@jonathanmoss.me>2018-08-02 22:29:53 -0400
commit8d15f69abd6502cedbc64597085bddfd9774b7a5 (patch)
treee0ecd0c0301d3c142761376e8089ef09e6661f20 /test/parallel/test-stream-transform-final.js
parentce98e2e989ec52f6aa205c8b340ff214aba5f060 (diff)
downloadandroid-node-v8-8d15f69abd6502cedbc64597085bddfd9774b7a5.tar.gz
android-node-v8-8d15f69abd6502cedbc64597085bddfd9774b7a5.tar.bz2
android-node-v8-8d15f69abd6502cedbc64597085bddfd9774b7a5.zip
test: remove third argument from assert.strictEqual()
In file test/parallel/test-stream-transform-final.js the ten calls to assert.strictEqual() use a string literal as third argument. When a AssertionError occurs, it reports the string literal and not the first two arguments, so the third agrument is removed and made a comment just above the call to assert.strictEqual(). PR-URL: https://github.com/nodejs/node/pull/22051 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'test/parallel/test-stream-transform-final.js')
-rw-r--r--test/parallel/test-stream-transform-final.js30
1 files changed, 20 insertions, 10 deletions
diff --git a/test/parallel/test-stream-transform-final.js b/test/parallel/test-stream-transform-final.js
index 22128b4d9a..3d6c4563c6 100644
--- a/test/parallel/test-stream-transform-final.js
+++ b/test/parallel/test-stream-transform-final.js
@@ -59,44 +59,54 @@ The order things are called
const t = new stream.Transform({
objectMode: true,
transform: common.mustCall(function(chunk, _, next) {
- assert.strictEqual(++state, chunk, 'transformCallback part 1');
+ // transformCallback part 1
+ assert.strictEqual(++state, chunk);
this.push(state);
- assert.strictEqual(++state, chunk + 2, 'transformCallback part 2');
+ // transformCallback part 2
+ assert.strictEqual(++state, chunk + 2);
process.nextTick(next);
}, 3),
final: common.mustCall(function(done) {
state++;
- assert.strictEqual(state, 10, 'finalCallback part 1');
+ // finalCallback part 1
+ assert.strictEqual(state, 10);
setTimeout(function() {
state++;
- assert.strictEqual(state, 11, 'finalCallback part 2');
+ // finalCallback part 2
+ assert.strictEqual(state, 11);
done();
}, 100);
}, 1),
flush: common.mustCall(function(done) {
state++;
- assert.strictEqual(state, 12, 'flushCallback part 1');
+ // flushCallback part 1
+ assert.strictEqual(state, 12);
process.nextTick(function() {
state++;
- assert.strictEqual(state, 15, 'flushCallback part 2');
+ // flushCallback part 2
+ assert.strictEqual(state, 15);
done();
});
}, 1)
});
t.on('finish', common.mustCall(function() {
state++;
- assert.strictEqual(state, 13, 'finishListener');
+ // finishListener
+ assert.strictEqual(state, 13);
}, 1));
t.on('end', common.mustCall(function() {
state++;
- assert.strictEqual(state, 16, 'end event');
+ // end event
+ assert.strictEqual(state, 16);
}, 1));
t.on('data', common.mustCall(function(d) {
- assert.strictEqual(++state, d + 1, 'dataListener');
+ // dataListener
+ assert.strictEqual(++state, d + 1);
}, 3));
t.write(1);
t.write(4);
t.end(7, common.mustCall(function() {
state++;
- assert.strictEqual(state, 14, 'endMethodCallback');
+ // endMethodCallback
+ assert.strictEqual(state, 14);
}, 1));