diff options
author | hectorcoronado <hectorcoronado.developer@gmail.com> | 2018-07-15 18:14:37 -0700 |
---|---|---|
committer | Trivikram Kamat <16024985+trivikr@users.noreply.github.com> | 2018-07-18 04:43:00 -0700 |
commit | cfe0c024fca5e12688de1c95af257092d03417cb (patch) | |
tree | f2cdee338c26df0e41503e5016eb0ecf6d541563 /test/parallel/test-stream-transform-final-sync.js | |
parent | b3f459e6cf0076915cfd0e9ea130e3ceaa4448d1 (diff) | |
download | android-node-v8-cfe0c024fca5e12688de1c95af257092d03417cb.tar.gz android-node-v8-cfe0c024fca5e12688de1c95af257092d03417cb.tar.bz2 android-node-v8-cfe0c024fca5e12688de1c95af257092d03417cb.zip |
test: remove 3rd arg from to assert.strictEqual()
prevents AssertionError from reporting string literal,
instead displays values of first 2 args passed to
assert.strictEqual()
PR-URL: https://github.com/nodejs/node/pull/21828
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/parallel/test-stream-transform-final-sync.js')
-rw-r--r-- | test/parallel/test-stream-transform-final-sync.js | 30 |
1 files changed, 20 insertions, 10 deletions
diff --git a/test/parallel/test-stream-transform-final-sync.js b/test/parallel/test-stream-transform-final-sync.js index 7dbd06d60c..666c1dce99 100644 --- a/test/parallel/test-stream-transform-final-sync.js +++ b/test/parallel/test-stream-transform-final-sync.js @@ -59,42 +59,52 @@ The order things are called const t = new stream.Transform({ objectMode: true, transform: common.mustCall(function(chunk, _, next) { - assert.strictEqual(++state, chunk, 'transformCallback part 1'); + // transformCallback part 1 + assert.strictEqual(++state, chunk); this.push(state); - assert.strictEqual(++state, chunk + 2, 'transformCallback part 2'); + // transformCallback part 2 + assert.strictEqual(++state, chunk + 2); process.nextTick(next); }, 3), final: common.mustCall(function(done) { state++; - assert.strictEqual(state, 10, 'finalCallback part 1'); + // finalCallback part 1 + assert.strictEqual(state, 10); state++; - assert.strictEqual(state, 11, 'finalCallback part 2'); + // finalCallback part 2 + assert.strictEqual(state, 11); done(); }, 1), flush: common.mustCall(function(done) { state++; - assert.strictEqual(state, 12, 'flushCallback part 1'); + // fluchCallback part 1 + assert.strictEqual(state, 12); process.nextTick(function() { state++; - assert.strictEqual(state, 15, 'flushCallback part 2'); + // fluchCallback part 2 + assert.strictEqual(state, 15); done(); }); }, 1) }); t.on('finish', common.mustCall(function() { state++; - assert.strictEqual(state, 13, 'finishListener'); + // finishListener + assert.strictEqual(state, 13); }, 1)); t.on('end', common.mustCall(function() { state++; - assert.strictEqual(state, 16, 'end event'); + // endEvent + assert.strictEqual(state, 16); }, 1)); t.on('data', common.mustCall(function(d) { - assert.strictEqual(++state, d + 1, 'dataListener'); + // dataListener + assert.strictEqual(++state, d + 1); }, 3)); t.write(1); t.write(4); t.end(7, common.mustCall(function() { state++; - assert.strictEqual(state, 14, 'endMethodCallback'); + // endMethodCallback + assert.strictEqual(state, 14); }, 1)); |