diff options
| author | Hristijan Gjorgjievski <hristijan_kiko123@hotmail.com> | 2018-06-06 13:02:16 +1000 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-06-08 21:42:01 -0700 |
| commit | ef1f13004114df9a01d26b22d8e4c090b9833c4f (patch) | |
| tree | 5ecc43fdca4fe39d1607e4769d9e82af0d73ecfa /test/parallel/test-stream-pipe-await-drain.js | |
| parent | 872c331a930df3e44e8f5db5a90a0383e8d0491b (diff) | |
| download | android-node-v8-ef1f13004114df9a01d26b22d8e4c090b9833c4f.tar.gz android-node-v8-ef1f13004114df9a01d26b22d8e4c090b9833c4f.tar.bz2 android-node-v8-ef1f13004114df9a01d26b22d8e4c090b9833c4f.zip | |
test: improve assert error messages
Improve the assert error message so it includes actual value in
the error message.
PR-URL: https://github.com/nodejs/node/pull/21160
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/parallel/test-stream-pipe-await-drain.js')
| -rw-r--r-- | test/parallel/test-stream-pipe-await-drain.js | 20 |
1 files changed, 14 insertions, 6 deletions
diff --git a/test/parallel/test-stream-pipe-await-drain.js b/test/parallel/test-stream-pipe-await-drain.js index 5bdf480084..53cf54940d 100644 --- a/test/parallel/test-stream-pipe-await-drain.js +++ b/test/parallel/test-stream-pipe-await-drain.js @@ -23,8 +23,12 @@ writer1._write = common.mustCall(function(chunk, encoding, cb) { }, 1); writer1.once('chunk-received', function() { - assert.strictEqual(reader._readableState.awaitDrain, 0, - 'initial value is not 0'); + assert.strictEqual( + reader._readableState.awaitDrain, + 0, + 'awaitDrain initial value should be 0, actual is ' + + reader._readableState.awaitDrain + ); setImmediate(function() { // This one should *not* get through to writer1 because writer2 is not // "done" processing. @@ -35,8 +39,10 @@ writer1.once('chunk-received', function() { // A "slow" consumer: writer2._write = common.mustCall(function(chunk, encoding, cb) { assert.strictEqual( - reader._readableState.awaitDrain, 1, - 'awaitDrain isn\'t 1 after first push' + reader._readableState.awaitDrain, + 1, + 'awaitDrain should be 1 after first push, actual is ' + + reader._readableState.awaitDrain ); // Not calling cb here to "simulate" slow stream. // This should be called exactly once, since the first .write() call @@ -45,8 +51,10 @@ writer2._write = common.mustCall(function(chunk, encoding, cb) { writer3._write = common.mustCall(function(chunk, encoding, cb) { assert.strictEqual( - reader._readableState.awaitDrain, 2, - 'awaitDrain isn\'t 2 after second push' + reader._readableState.awaitDrain, + 2, + 'awaitDrain should be 2 after second push, actual is ' + + reader._readableState.awaitDrain ); // Not calling cb here to "simulate" slow stream. // This should be called exactly once, since the first .write() call |