aboutsummaryrefslogtreecommitdiff
path: root/test/parallel/test-stream-pipe-await-drain-manual-resume.js
diff options
context:
space:
mode:
authorran <abbshrsoufii@gmail.com>2019-08-26 17:00:06 +0800
committerAnna Henningsen <anna@addaleax.net>2019-08-26 15:20:50 +0200
commit698a29420f92844478101ec1fccdc81b46954e2e (patch)
tree47e4f9c728981a0e9377d622a957632c39ccf61c /test/parallel/test-stream-pipe-await-drain-manual-resume.js
parent627bf59e8ddd9826720c45f430c2a2e489df6e66 (diff)
downloadandroid-node-v8-698a29420f92844478101ec1fccdc81b46954e2e.tar.gz
android-node-v8-698a29420f92844478101ec1fccdc81b46954e2e.tar.bz2
android-node-v8-698a29420f92844478101ec1fccdc81b46954e2e.zip
stream: fix readable state `awaitDrain` increase in recursion
PR-URL: https://github.com/nodejs/node/pull/27572 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'test/parallel/test-stream-pipe-await-drain-manual-resume.js')
-rw-r--r--test/parallel/test-stream-pipe-await-drain-manual-resume.js25
1 files changed, 13 insertions, 12 deletions
diff --git a/test/parallel/test-stream-pipe-await-drain-manual-resume.js b/test/parallel/test-stream-pipe-await-drain-manual-resume.js
index 37acead996..a95a5e05ae 100644
--- a/test/parallel/test-stream-pipe-await-drain-manual-resume.js
+++ b/test/parallel/test-stream-pipe-await-drain-manual-resume.js
@@ -28,10 +28,10 @@ readable.pipe(writable);
readable.once('pause', common.mustCall(() => {
assert.strictEqual(
- readable._readableState.awaitDrain,
- 1,
- 'Expected awaitDrain to equal 1 but instead got ' +
- `${readable._readableState.awaitDrain}`
+ readable._readableState.awaitDrainWriters,
+ writable,
+ 'Expected awaitDrainWriters to be a Writable but instead got ' +
+ `${readable._readableState.awaitDrainWriters}`
);
// First pause, resume manually. The next write() to writable will still
// return false, because chunks are still being buffered, so it will increase
@@ -43,10 +43,10 @@ readable.once('pause', common.mustCall(() => {
readable.once('pause', common.mustCall(() => {
assert.strictEqual(
- readable._readableState.awaitDrain,
- 1,
- '.resume() should not reset the counter but instead got ' +
- `${readable._readableState.awaitDrain}`
+ readable._readableState.awaitDrainWriters,
+ writable,
+ '.resume() should not reset the awaitDrainWriters, but instead got ' +
+ `${readable._readableState.awaitDrainWriters}`
);
// Second pause, handle all chunks from now on. Once all callbacks that
// are currently queued up are handled, the awaitDrain drain counter should
@@ -65,10 +65,11 @@ readable.push(null);
writable.on('finish', common.mustCall(() => {
assert.strictEqual(
- readable._readableState.awaitDrain,
- 0,
- 'awaitDrain should equal 0 after all chunks are written but instead got' +
- `${readable._readableState.awaitDrain}`
+ readable._readableState.awaitDrainWriters,
+ null,
+ `awaitDrainWriters should be reset to null
+ after all chunks are written but instead got
+ ${readable._readableState.awaitDrainWriters}`
);
// Everything okay, all chunks were written.
}));