test: use random ports where possible

This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.

PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

1 files changed, 24 insertions, 24 deletions

diff --git a/test/parallel/test-socket-write-after-fin-error.js b/test/parallel/test-socket-write-after-fin-error.js
index 226440ec50..480d5d2edc 100644
--- a/test/parallel/test-socket-write-after-fin-error.js
+++ b/test/parallel/test-socket-write-after-fin-error.js
@@ -1,5 +1,5 @@
 'use strict';
-var common = require('../common');
+require('../common');
 var assert = require('assert');
 
 // This is similar to simple/test-socket-write-after-fin, except that
@@ -31,30 +31,30 @@ var server = net.createServer(function(sock) {
   });
   server.close();
 });
-server.listen(common.PORT);
+server.listen(0, function() {
+  var sock = net.connect(this.address().port);
+  sock.setEncoding('utf8');
+  sock.on('data', function(c) {
+    clientData += c;
+  });
 
-var sock = net.connect(common.PORT);
-sock.setEncoding('utf8');
-sock.on('data', function(c) {
-  clientData += c;
-});
+  sock.on('end', function() {
+    gotClientEnd = true;
+  });
 
-sock.on('end', function() {
-  gotClientEnd = true;
-});
+  process.on('exit', function() {
+    assert.equal(clientData, '');
+    assert.equal(serverData, 'hello1hello2hello3\nTHUNDERMUSCLE!');
+    assert(gotClientEnd);
+    assert(gotServerEnd);
+    assert(gotServerError);
+    assert.equal(gotServerError.code, 'EPIPE');
+    assert.notEqual(gotServerError.message, 'write after end');
+    console.log('ok');
+  });
 
-process.on('exit', function() {
-  assert.equal(clientData, '');
-  assert.equal(serverData, 'hello1hello2hello3\nTHUNDERMUSCLE!');
-  assert(gotClientEnd);
-  assert(gotServerEnd);
-  assert(gotServerError);
-  assert.equal(gotServerError.code, 'EPIPE');
-  assert.notEqual(gotServerError.message, 'write after end');
-  console.log('ok');
+  sock.write('hello1');
+  sock.write('hello2');
+  sock.write('hello3\n');
+  sock.end('THUNDERMUSCLE!');
 });
-
-sock.write('hello1');
-sock.write('hello2');
-sock.write('hello3\n');
-sock.end('THUNDERMUSCLE!');