diff options
author | Israel Ortiz <soy@israelortiz.com> | 2018-10-12 11:46:07 -0700 |
---|---|---|
committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-10-15 15:34:45 +0200 |
commit | a039c863c4ab4210bb7435fe6c13f130c8a44781 (patch) | |
tree | 599eb534f9c1c193bc5134b0b625a7e002eca2f2 /test/parallel/test-repl.js | |
parent | 99c16900c8eba7baa64dbd4f5f978412871410a2 (diff) | |
download | android-node-v8-a039c863c4ab4210bb7435fe6c13f130c8a44781.tar.gz android-node-v8-a039c863c4ab4210bb7435fe6c13f130c8a44781.tar.bz2 android-node-v8-a039c863c4ab4210bb7435fe6c13f130c8a44781.zip |
test: fix parameters in test-repl.js
fixed order of parameters in assert.strictEqual() assertion functions,
first argument provided was the expected value and the second value
was the actual value.
this is backwards from the documentation for assertions like
assert.strictEqual() where the first value being tested and the second
value is the expected value
PR-URL: https://github.com/nodejs/node/pull/23609
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Diffstat (limited to 'test/parallel/test-repl.js')
-rw-r--r-- | test/parallel/test-repl.js | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/test/parallel/test-repl.js b/test/parallel/test-repl.js index 49e718da0f..f8261dedd9 100644 --- a/test/parallel/test-repl.js +++ b/test/parallel/test-repl.js @@ -784,8 +784,8 @@ function startTCPRepl() { client.setEncoding('utf8'); client.on('connect', common.mustCall(() => { - assert.strictEqual(true, client.readable); - assert.strictEqual(true, client.writable); + assert.strictEqual(client.readable, true); + assert.strictEqual(client.writable, true); resolveSocket(client); })); @@ -827,8 +827,8 @@ function startUnixRepl() { client.setEncoding('utf8'); client.on('connect', common.mustCall(() => { - assert.strictEqual(true, client.readable); - assert.strictEqual(true, client.writable); + assert.strictEqual(client.readable, true); + assert.strictEqual(client.writable, true); resolveSocket(client); })); |