diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2017-10-25 12:06:40 +0200 |
|---|---|---|
| committer | Ben Noordhuis <info@bnoordhuis.nl> | 2017-11-07 19:51:51 +0100 |
| commit | 90a43906ab5ca8bdf154fb7644d70da9e3acdf00 (patch) | |
| tree | 59b0e27656689f7ec94ccfc2c0d032d62f37d9ac /test/parallel/test-repl.js | |
| parent | 6563e56aef5287646aa433bfe088a73a2bea855d (diff) | |
| download | android-node-v8-90a43906ab5ca8bdf154fb7644d70da9e3acdf00.tar.gz android-node-v8-90a43906ab5ca8bdf154fb7644d70da9e3acdf00.tar.bz2 android-node-v8-90a43906ab5ca8bdf154fb7644d70da9e3acdf00.zip | |
repl: show proxies as Proxy objects
Before this commit they transparently invoked their magic methods but
that sometimes throws confusing exceptions with misbehaving proxies.
This change is not wholly uncontroversial but we can always change the
default if necessary. Let's see how it goes.
Fixes: https://github.com/nodejs/node/issues/16483
PR-URL: https://github.com/nodejs/node/pull/16485
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/parallel/test-repl.js')
| -rw-r--r-- | test/parallel/test-repl.js | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/test/parallel/test-repl.js b/test/parallel/test-repl.js index 6d4f0d8c7a..a771b32431 100644 --- a/test/parallel/test-repl.js +++ b/test/parallel/test-repl.js @@ -413,6 +413,17 @@ function error_test() { expect: `${prompt_multiline}${prompt_multiline}undefined\n${prompt_unix}` }, + // https://github.com/nodejs/node/issues/16483 + { + client: client_unix, send: 'new Proxy({x:42}, {get(){throw null}});', + expect: `Proxy [ { x: 42 }, { get: [Function: get] } ]\n${prompt_unix}` + }, + { + client: client_unix, + send: 'repl.writer.options.showProxy = false, new Proxy({x:42}, {});', + expect: `{ x: 42 }\n${prompt_unix}` + }, + // Newline within template string maintains whitespace. { client: client_unix, send: '`foo \n`', expect: `${prompt_multiline}'foo \\n'\n${prompt_unix}` }, |