repl: refactor tests to not rely on timing

Tests relying on synchronous timing have been migrated to use events.

PR-URL: https://github.com/nodejs/node/pull/17828
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

1 files changed, 2 insertions, 6 deletions

diff --git a/test/parallel/test-repl-recoverable.js b/test/parallel/test-repl-recoverable.js
index 6788d84595..c1767bbc4d 100644
--- a/test/parallel/test-repl-recoverable.js
+++ b/test/parallel/test-repl-recoverable.js
@@ -4,14 +4,11 @@ const common = require('../common');
 const assert = require('assert');
 const repl = require('repl');
 
-let evalCount = 0;
 let recovered = false;
 let rendered = false;
 
 function customEval(code, context, file, cb) {
-  evalCount++;
-
-  return cb(evalCount === 1 ? new repl.Recoverable() : null, true);
+  return cb(!recovered ? new repl.Recoverable() : null, true);
 }
 
 const putIn = new common.ArrayStream();
@@ -26,7 +23,7 @@ putIn.write = function(msg) {
   }
 };
 
-repl.start('', putIn, customEval);
+repl.start('', putIn, common.mustCall(customEval, 2));
 
 // https://github.com/nodejs/node/issues/2939
 // Expose recoverable errors to the consumer.
@@ -36,5 +33,4 @@ putIn.emit('data', '2\n');
 process.on('exit', function() {
   assert(recovered, 'REPL never recovered');
   assert(rendered, 'REPL never rendered the result');
-  assert.strictEqual(evalCount, 2);
 });