diff options
| author | Ruben Bridgewater <ruben@bridgewater.de> | 2018-05-14 16:16:33 +0200 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-05-19 17:55:57 +0200 |
| commit | becc3ec372baeef0a4b89923968d874010966c49 (patch) | |
| tree | d2b29d41da5e3ebde58d2ae04612e28b988c6b28 /test/parallel/test-repl-persistent-history.js | |
| parent | f954aba39ee02193beb2dbddc6c0ea0edcca7c74 (diff) | |
| download | android-node-v8-becc3ec372baeef0a4b89923968d874010966c49.tar.gz android-node-v8-becc3ec372baeef0a4b89923968d874010966c49.tar.bz2 android-node-v8-becc3ec372baeef0a4b89923968d874010966c49.zip | |
test: remove common.globalCheck
This flag is partially used in tests where it was not necessary and
it is always possible to replace this flag with
`common.allowGlobals`. This makes sure all globals are truly tested
for.
PR-URL: https://github.com/nodejs/node/pull/20717
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'test/parallel/test-repl-persistent-history.js')
| -rw-r--r-- | test/parallel/test-repl-persistent-history.js | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/test/parallel/test-repl-persistent-history.js b/test/parallel/test-repl-persistent-history.js index 4d0330272a..bb10085ecc 100644 --- a/test/parallel/test-repl-persistent-history.js +++ b/test/parallel/test-repl-persistent-history.js @@ -216,9 +216,6 @@ function runTest(assertCleaned) { throw err; } - // The REPL registers 'module' and 'require' globals - common.allowGlobals(repl.context.module, repl.context.require); - repl.once('close', () => { if (repl._flushing) { repl.once('flushHistory', onClose); |