diff options
author | Bradley Farias <bradley.meck@gmail.com> | 2017-12-22 11:19:50 -0600 |
---|---|---|
committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-02-10 14:19:54 +0100 |
commit | de848ac1e0483327a2ce8716c3f8567eaeacb660 (patch) | |
tree | 5395e33d22cd318f618b24752e178f68f40e851f /test/parallel/test-repl-null.js | |
parent | 6007a9cc0e361d428123e4c0f74024c6cd7815f4 (diff) | |
download | android-node-v8-de848ac1e0483327a2ce8716c3f8567eaeacb660.tar.gz android-node-v8-de848ac1e0483327a2ce8716c3f8567eaeacb660.tar.bz2 android-node-v8-de848ac1e0483327a2ce8716c3f8567eaeacb660.zip |
repl: refactor tests to not rely on timing
Tests relying on synchronous timing have been migrated to use events.
PR-URL: https://github.com/nodejs/node/pull/17828
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
Diffstat (limited to 'test/parallel/test-repl-null.js')
-rw-r--r-- | test/parallel/test-repl-null.js | 21 |
1 files changed, 20 insertions, 1 deletions
diff --git a/test/parallel/test-repl-null.js b/test/parallel/test-repl-null.js index 66d09b28f2..2748cfa780 100644 --- a/test/parallel/test-repl-null.js +++ b/test/parallel/test-repl-null.js @@ -1,9 +1,28 @@ 'use strict'; -require('../common'); +const common = require('../common'); const repl = require('repl'); const assert = require('assert'); +const callbacks = [ + common.mustCall((err, value) => { + assert.ifError(err); + assert.strictEqual(value, undefined); + }) +]; const replserver = new repl.REPLServer(); +const $eval = replserver.eval; +replserver.eval = function(code, context, file, cb) { + const expected = callbacks.shift(); + return $eval.call(this, code, context, file, (...args) => { + try { + expected(...args); + } catch (e) { + console.error(e); + process.exit(1); + } + cb(...args); + }); +}; replserver._inTemplateLiteral = true; |