diff options
author | Ruben Bridgewater <ruben@bridgewater.de> | 2018-05-14 16:16:33 +0200 |
---|---|---|
committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-05-19 17:55:57 +0200 |
commit | becc3ec372baeef0a4b89923968d874010966c49 (patch) | |
tree | d2b29d41da5e3ebde58d2ae04612e28b988c6b28 /test/parallel/test-repl-autolibs.js | |
parent | f954aba39ee02193beb2dbddc6c0ea0edcca7c74 (diff) | |
download | android-node-v8-becc3ec372baeef0a4b89923968d874010966c49.tar.gz android-node-v8-becc3ec372baeef0a4b89923968d874010966c49.tar.bz2 android-node-v8-becc3ec372baeef0a4b89923968d874010966c49.zip |
test: remove common.globalCheck
This flag is partially used in tests where it was not necessary and
it is always possible to replace this flag with
`common.allowGlobals`. This makes sure all globals are truly tested
for.
PR-URL: https://github.com/nodejs/node/pull/20717
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'test/parallel/test-repl-autolibs.js')
-rw-r--r-- | test/parallel/test-repl-autolibs.js | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/test/parallel/test-repl-autolibs.js b/test/parallel/test-repl-autolibs.js index 52234deb5e..024dd971bf 100644 --- a/test/parallel/test-repl-autolibs.js +++ b/test/parallel/test-repl-autolibs.js @@ -25,9 +25,6 @@ const assert = require('assert'); const util = require('util'); const repl = require('repl'); -// This test adds global variables -common.globalCheck = false; - const putIn = new common.ArrayStream(); repl.start('', putIn, null, true); @@ -65,6 +62,7 @@ function test2() { }; const val = {}; global.url = val; + common.allowGlobals(val); assert(!gotWrite); putIn.run(['url']); assert(gotWrite); |