test: cleanup IIFE tests

A number of test files use IIFEs to separate distinct tests from
each other in the same file. The project has been moving toward
using block scopes and let/const in favor of IIFEs. This commit
moves IIFE tests to block scopes. Some additional cleanup such
as use of strictEqual() and common.mustCall() is also included.

PR-URL: https://github.com/nodejs/node/pull/7694
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

1 files changed, 4 insertions, 4 deletions

diff --git a/test/parallel/test-querystring.js b/test/parallel/test-querystring.js
index 5d52fe6544..37cf66705d 100644
--- a/test/parallel/test-querystring.js
+++ b/test/parallel/test-querystring.js
@@ -134,7 +134,7 @@ qsNoMungeTestCases.forEach(function(testCase) {
 });
 
 // test the nested qs-in-qs case
-(function() {
+{
   const f = qs.parse('a=b&q=x%3Dy%26y%3Dz');
   check(f, createWithNoPrototype([
     { key: 'a', value: 'b'},
@@ -147,10 +147,10 @@ qsNoMungeTestCases.forEach(function(testCase) {
     {key: 'y', value: 'z' }
   ]);
   check(f.q, expectedInternal);
-})();
+}
 
 // nested in colon
-(function() {
+{
   const f = qs.parse('a:b;q:x%3Ay%3By%3Az', ';', ':');
   check(f, createWithNoPrototype([
     {key: 'a', value: 'b'},
@@ -162,7 +162,7 @@ qsNoMungeTestCases.forEach(function(testCase) {
     {key: 'y', value: 'z' }
   ]);
   check(f.q, expectedInternal);
-})();
+}
 
 // now test stringifying