diff options
| author | Anna Henningsen <anna@addaleax.net> | 2017-09-14 17:58:53 +0200 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2017-09-20 10:45:33 -0300 |
| commit | 602fd36d952af2ee1104b73cf619b50020f08849 (patch) | |
| tree | 4cc577d1a0b95869a42905fc3c335304cb04ab33 /test/parallel/test-promises-unhandled-rejections.js | |
| parent | 750c0802f5e1804284b59c2180d46dc6ba1aa6b1 (diff) | |
| download | android-node-v8-602fd36d952af2ee1104b73cf619b50020f08849.tar.gz android-node-v8-602fd36d952af2ee1104b73cf619b50020f08849.tar.bz2 android-node-v8-602fd36d952af2ee1104b73cf619b50020f08849.zip | |
domain: remove `.dispose()`
`domain.dispose()` is generally considered an anti-pattern, has been
runtime-deprecated for over 4 years, and is a part of the `domain`
module that can not be emulated by `async_hooks`; so remove it.
Ref: https://nodejs.org/en/docs/guides/domain-postmortem/
Ref: 4a74fc9776d825115849997f4adacb46f4303494
PR-URL: https://github.com/nodejs/node/pull/15412
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Diffstat (limited to 'test/parallel/test-promises-unhandled-rejections.js')
| -rw-r--r-- | test/parallel/test-promises-unhandled-rejections.js | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/test/parallel/test-promises-unhandled-rejections.js b/test/parallel/test-promises-unhandled-rejections.js index 7a367920b0..4494e5084d 100644 --- a/test/parallel/test-promises-unhandled-rejections.js +++ b/test/parallel/test-promises-unhandled-rejections.js @@ -634,7 +634,6 @@ asyncTest( onUnhandledSucceed(done, function(reason, promise) { assert.strictEqual(reason, e); assert.strictEqual(domainReceivedError, domainError); - d.dispose(); }); Promise.reject(e); process.nextTick(function() { |