process: remove pushValueToArray in EnvEnumerator

Instead of calling into JS from C++ to push values into an array,
use the new Array::New API that takes a pointer and a length
directly.

PR-URL: https://github.com/nodejs/node/pull/24264
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

1 files changed, 6 insertions, 0 deletions

diff --git a/test/parallel/test-process-env.js b/test/parallel/test-process-env.js
index 60f4d6f4fa..51cc637d06 100644
--- a/test/parallel/test-process-env.js
+++ b/test/parallel/test-process-env.js
@@ -91,6 +91,7 @@ assert.strictEqual(5, date.getHours());
 // case-sensitive on other platforms.
 process.env.TEST = 'test';
 assert.strictEqual(process.env.TEST, 'test');
+
 // Check both mixed case and lower case, to avoid any regressions that might
 // simply convert input to lower case.
 if (common.isWindows) {
@@ -100,3 +101,8 @@ if (common.isWindows) {
   assert.strictEqual(process.env.test, undefined);
   assert.strictEqual(process.env.teST, undefined);
 }
+
+{
+  const keys = Object.keys(process.env);
+  assert.ok(keys.length > 0);
+}