diff options
| author | Brian White <mscdex@mscdex.net> | 2016-05-29 03:06:56 -0400 |
|---|---|---|
| committer | Brian White <mscdex@mscdex.net> | 2016-06-10 22:30:55 -0400 |
| commit | 2bc7841d0fcdd066fe477873229125b6f003b693 (patch) | |
| tree | 2816555ef6ad2fc828a75dc3c564f8faa2dee6c7 /test/parallel/test-net-socket-timeout-unref.js | |
| parent | 624734e640717a826ab1a18845c083a638dc5ce6 (diff) | |
| download | android-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.tar.gz android-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.tar.bz2 android-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.zip | |
test: use random ports where possible
This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.
PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Diffstat (limited to 'test/parallel/test-net-socket-timeout-unref.js')
| -rw-r--r-- | test/parallel/test-net-socket-timeout-unref.js | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/parallel/test-net-socket-timeout-unref.js b/test/parallel/test-net-socket-timeout-unref.js index bbc2dffcc1..fb4f6a658e 100644 --- a/test/parallel/test-net-socket-timeout-unref.js +++ b/test/parallel/test-net-socket-timeout-unref.js @@ -9,7 +9,7 @@ const server = net.createServer(function(c) { c.write('hello'); c.unref(); }); -server.listen(common.PORT); +server.listen(0); server.unref(); var connections = 0; @@ -17,7 +17,7 @@ const sockets = []; const delays = [8, 5, 3, 6, 2, 4]; delays.forEach(function(T) { - const socket = net.createConnection(common.PORT, 'localhost'); + const socket = net.createConnection(server.address().port, 'localhost'); socket.on('connect', common.mustCall(function() { if (++connections === delays.length) { sockets.forEach(function(s) { |