diff options
author | Aditya Anand <aditya.anandmc@gmail.com> | 2017-04-17 17:20:17 +0530 |
---|---|---|
committer | James M Snell <jasnell@gmail.com> | 2017-05-09 13:25:05 -0700 |
commit | 94eed0fb11d733c8d18b174ae9ba71ead3da4ca8 (patch) | |
tree | c26c288044cb852e4ce65792e9c76e345e7805e7 /test/parallel/test-net-localerror.js | |
parent | 824fb49a706dc8e12911d5d142aa8fc779fe59d2 (diff) | |
download | android-node-v8-94eed0fb11d733c8d18b174ae9ba71ead3da4ca8.tar.gz android-node-v8-94eed0fb11d733c8d18b174ae9ba71ead3da4ca8.tar.bz2 android-node-v8-94eed0fb11d733c8d18b174ae9ba71ead3da4ca8.zip |
test: use dynamic port instead of common.PORT
Remove common.PORT from, test-net-connect-immediate-destroy,
test-net-options-lookup, test-net-connect-local-error,
test-net-connect-handle-econnrefused, test-net-socket-destroy-twice,
test-net-better-error-messages-port-hostname, test-net-localerror,
to reduce possibility that a dynamic port used in another test will
collide with common.PORT.
Moved test-net-listen-shared-ports, test-net-better-error-messages-port
from tests/parallel to test/sequential
Refs: https://github.com/nodejs/node/issues/12376
PR-URL: https://github.com/nodejs/node/pull/12473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Diffstat (limited to 'test/parallel/test-net-localerror.js')
-rw-r--r-- | test/parallel/test-net-localerror.js | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/test/parallel/test-net-localerror.js b/test/parallel/test-net-localerror.js index 03f8e99c5d..845983843d 100644 --- a/test/parallel/test-net-localerror.js +++ b/test/parallel/test-net-localerror.js @@ -20,24 +20,25 @@ // USE OR OTHER DEALINGS IN THE SOFTWARE. 'use strict'; -const common = require('../common'); +require('../common'); const assert = require('assert'); const net = require('net'); +// Using port 0 as localPort / localAddress is already invalid. connect({ host: 'localhost', - port: common.PORT, + port: 0, localPort: 'foobar', }, /^TypeError: "localPort" option should be a number: foobar$/); connect({ host: 'localhost', - port: common.PORT, + port: 0, localAddress: 'foobar', }, /^TypeError: "localAddress" option must be a valid IP: foobar$/); function connect(opts, msg) { - assert.throws(function() { + assert.throws(() => { net.connect(opts); }, msg); } |