aboutsummaryrefslogtreecommitdiff
path: root/test/parallel/test-net-connect-immediate-finish.js
diff options
context:
space:
mode:
authorSakthipriyan Vairamani <thechargingvolcano@gmail.com>2015-11-08 16:31:51 +0530
committerJames M Snell <jasnell@gmail.com>2015-11-09 11:30:02 -0800
commit570725840c4180757a9e6a112555225679eb1a8c (patch)
tree992c713bafc07e3f971993b6669e49c467157acc /test/parallel/test-net-connect-immediate-finish.js
parent20285ad17755187ece16b8a5effeaa87f5407da2 (diff)
downloadandroid-node-v8-570725840c4180757a9e6a112555225679eb1a8c.tar.gz
android-node-v8-570725840c4180757a9e6a112555225679eb1a8c.tar.bz2
android-node-v8-570725840c4180757a9e6a112555225679eb1a8c.zip
test: use really invalid hostname
On my slow Ubuntu 14.04 machine, this fails to resolve the host name used (`no.way.you.will.resolve.this`) and it times out in local testing. This patch uses an invalid name (`...`) and does stricter validation of the error returned. PR-URL: https://github.com/nodejs/node/pull/3711 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/parallel/test-net-connect-immediate-finish.js')
-rw-r--r--test/parallel/test-net-connect-immediate-finish.js28
1 files changed, 12 insertions, 16 deletions
diff --git a/test/parallel/test-net-connect-immediate-finish.js b/test/parallel/test-net-connect-immediate-finish.js
index 086cf91042..a5403732ec 100644
--- a/test/parallel/test-net-connect-immediate-finish.js
+++ b/test/parallel/test-net-connect-immediate-finish.js
@@ -1,21 +1,17 @@
'use strict';
-var common = require('../common');
-var assert = require('assert');
-var net = require('net');
+const common = require('../common');
+const assert = require('assert');
+const net = require('net');
-var gotError = false;
+const client = net.connect({host: '...', port: common.PORT});
-var client = net.connect({
- host: 'no.way.you.will.resolve.this',
- port: common.PORT
-});
-
-client.once('error', function(err) {
- gotError = true;
-});
+client.once('error', common.mustCall(function(err) {
+ assert(err);
+ assert.strictEqual(err.code, err.errno);
+ assert.strictEqual(err.code, 'ENOTFOUND');
+ assert.strictEqual(err.host, err.hostname);
+ assert.strictEqual(err.host, '...');
+ assert.strictEqual(err.syscall, 'getaddrinfo');
+}));
client.end();
-
-process.on('exit', function() {
- assert(gotError);
-});