summaryrefslogtreecommitdiff
path: root/test/parallel/test-internal-socket-list-receive.js
diff options
context:
space:
mode:
authorAnatoli Papirovski <apapirovski@mac.com>2018-06-03 11:49:41 +0200
committerAnatoli Papirovski <apapirovski@mac.com>2018-06-07 09:43:10 -0400
commitaf2a1045631028dfad0dd5d3eb4c4866fdf55730 (patch)
tree1abea11dd9ee5e998ff8227a698e9b3642513fca /test/parallel/test-internal-socket-list-receive.js
parent6858ab5d01084d93c75ddac3017017b8a870bc1d (diff)
downloadandroid-node-v8-af2a1045631028dfad0dd5d3eb4c4866fdf55730.tar.gz
android-node-v8-af2a1045631028dfad0dd5d3eb4c4866fdf55730.tar.bz2
android-node-v8-af2a1045631028dfad0dd5d3eb4c4866fdf55730.zip
child_process: swallow errors in internal communication
Much like with NODE_HANDLE_ACK, the internal protocol for communication about the sent socket should not expose its errors to the users when those async calls are not initiated by them. PR-URL: https://github.com/nodejs/node/pull/21108 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
Diffstat (limited to 'test/parallel/test-internal-socket-list-receive.js')
-rw-r--r--test/parallel/test-internal-socket-list-receive.js6
1 files changed, 3 insertions, 3 deletions
diff --git a/test/parallel/test-internal-socket-list-receive.js b/test/parallel/test-internal-socket-list-receive.js
index c0eb223719..e7e6488760 100644
--- a/test/parallel/test-internal-socket-list-receive.js
+++ b/test/parallel/test-internal-socket-list-receive.js
@@ -12,7 +12,7 @@ const key = 'test-key';
{
const child = Object.assign(new EventEmitter(), {
connected: false,
- send: common.mustNotCall()
+ _send: common.mustNotCall()
});
const list = new SocketListReceive(child, key);
@@ -24,7 +24,7 @@ const key = 'test-key';
{
const child = Object.assign(new EventEmitter(), {
connected: true,
- send: common.mustCall((msg) => {
+ _send: common.mustCall((msg) => {
assert.strictEqual(msg.cmd, 'NODE_SOCKET_ALL_CLOSED');
assert.strictEqual(msg.key, key);
})
@@ -38,7 +38,7 @@ const key = 'test-key';
{
const child = Object.assign(new EventEmitter(), {
connected: true,
- send: common.mustCall((msg) => {
+ _send: common.mustCall((msg) => {
assert.strictEqual(msg.cmd, 'NODE_SOCKET_COUNT');
assert.strictEqual(msg.key, key);
assert.strictEqual(msg.count, 0);