aboutsummaryrefslogtreecommitdiff
path: root/test/parallel/test-internal-errors.js
diff options
context:
space:
mode:
authorRich Trott <rtrott@gmail.com>2018-03-07 20:08:17 -0800
committerRich Trott <rtrott@gmail.com>2018-03-09 20:12:28 -0800
commita910320ef3aa379ac8c64d8b166b165c53bb1578 (patch)
tree5635259f04df184030f2687eeb93add57c852950 /test/parallel/test-internal-errors.js
parent7314b170a49fd5f24ef91f95dfc6ee3bf93b73ae (diff)
downloadandroid-node-v8-a910320ef3aa379ac8c64d8b166b165c53bb1578.tar.gz
android-node-v8-a910320ef3aa379ac8c64d8b166b165c53bb1578.tar.bz2
android-node-v8-a910320ef3aa379ac8c64d8b166b165c53bb1578.zip
test: do not check text for engine-generated error
In test-tls-wrap-event-emitter, the text of a TypeError is checked as part of the test. However, this text is generated by the JavaScript engine (V8) and not Node.js. Thus, we should not check the text as JS engine error messages can change without it being considered a breaking change for Node.js. A side effect is that node-chakracore will no longer need to patch this test to pass. PR-URL: https://github.com/nodejs/node/pull/19215 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/parallel/test-internal-errors.js')
0 files changed, 0 insertions, 0 deletions