src, i18n: cleanup usage of MaybeStackBuffer

- Templatize AsBuffer() and create a generic version for inclusion in
  the Buffer class
- Use MaybeStackBuffer::storage()
- If possible, avoid double conversion in ToASCII()/ToUnicode()
- More descriptive assertion error in tests

PR-URL: https://github.com/nodejs/node/pull/11464
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

1 files changed, 2 insertions, 2 deletions

diff --git a/test/parallel/test-icu-transcode.js b/test/parallel/test-icu-transcode.js
index 7bc10e7c5d..1c77427b15 100644
--- a/test/parallel/test-icu-transcode.js
+++ b/test/parallel/test-icu-transcode.js
@@ -22,9 +22,9 @@ const tests = {
 
 for (const test in tests) {
   const dest = buffer.transcode(orig, 'utf8', test);
-  assert.strictEqual(dest.length, tests[test].length);
+  assert.strictEqual(dest.length, tests[test].length, `utf8->${test} length`);
   for (let n = 0; n < tests[test].length; n++)
-    assert.strictEqual(dest[n], tests[test][n]);
+    assert.strictEqual(dest[n], tests[test][n], `utf8->${test} char ${n}`);
 }
 
 {