summaryrefslogtreecommitdiff
path: root/test/parallel/test-icu-punycode.js
diff options
context:
space:
mode:
authorRuben Bridgewater <ruben@bridgewater.de>2018-02-09 02:32:04 +0100
committerRuben Bridgewater <ruben@bridgewater.de>2018-02-16 16:53:47 +0100
commitcaee112e52b64f4bc1118c4a5fa5ad7b4211efea (patch)
tree7b60b49da3f863917a23ebc94c00bf2f13cc1348 /test/parallel/test-icu-punycode.js
parent4d3c3f039af08b954fbbba1e9a50979ffc98592b (diff)
downloadandroid-node-v8-caee112e52b64f4bc1118c4a5fa5ad7b4211efea.tar.gz
android-node-v8-caee112e52b64f4bc1118c4a5fa5ad7b4211efea.tar.bz2
android-node-v8-caee112e52b64f4bc1118c4a5fa5ad7b4211efea.zip
test: remove assert.doesNotThrow()
There is actually no reason to use `assert.doesNotThrow()` in the tests. If a test throws, just let the error bubble up right away instead of first catching it and then rethrowing it. PR-URL: https://github.com/nodejs/node/pull/18669 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'test/parallel/test-icu-punycode.js')
-rw-r--r--test/parallel/test-icu-punycode.js5
1 files changed, 2 insertions, 3 deletions
diff --git a/test/parallel/test-icu-punycode.js b/test/parallel/test-icu-punycode.js
index 7abcae4617..3ca30a6d16 100644
--- a/test/parallel/test-icu-punycode.js
+++ b/test/parallel/test-icu-punycode.js
@@ -34,13 +34,12 @@ const wptToASCIITests = require('../fixtures/url-toascii.js');
if (output === null) {
assert.throws(() => icu.toASCII(input),
errMessage, `ToASCII ${caseComment}`);
- assert.doesNotThrow(() => icu.toASCII(input, true),
- `ToASCII ${caseComment} in lenient mode`);
+ icu.toASCII(input, true);
} else {
assert.strictEqual(icu.toASCII(input), output, `ToASCII ${caseComment}`);
assert.strictEqual(icu.toASCII(input, true), output,
`ToASCII ${caseComment} in lenient mode`);
}
- assert.doesNotThrow(() => icu.toUnicode(input), `ToUnicode ${caseComment}`);
+ icu.toUnicode(input);
}
}