diff options
author | Ben Noordhuis <info@bnoordhuis.nl> | 2017-05-16 15:15:14 +0200 |
---|---|---|
committer | Ben Noordhuis <info@bnoordhuis.nl> | 2017-05-19 20:24:41 +0200 |
commit | 46e773c5db9ebc106823594b82f4ff14a0a004f3 (patch) | |
tree | 3db561120aac67b90f67c3e0102bf6885f80a050 /test/parallel/test-icu-data-dir.js | |
parent | 6f216710eb49436f0c372fbaf6da3e65ba9578c2 (diff) | |
download | android-node-v8-46e773c5db9ebc106823594b82f4ff14a0a004f3.tar.gz android-node-v8-46e773c5db9ebc106823594b82f4ff14a0a004f3.tar.bz2 android-node-v8-46e773c5db9ebc106823594b82f4ff14a0a004f3.zip |
src: check if --icu-data-dir= points to valid dir
Call uc_init() after u_setDataDirectory() to find out if the data
directory is actually valid.
This commit removes parallel/test-intl-no-icu-data, added in commit
46345b9 ("src: make --icu-data-dir= switch testable"). It no longer
works now that an invalid --icu-data-dir= argument is rejected.
Coverage is now provided by parallel/test-icu-data-dir.
Fixes: https://github.com/nodejs/node/issues/13043
Refs: https://github.com/nodejs/node-gyp/issues/1199
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Diffstat (limited to 'test/parallel/test-icu-data-dir.js')
-rw-r--r-- | test/parallel/test-icu-data-dir.js | 19 |
1 files changed, 19 insertions, 0 deletions
diff --git a/test/parallel/test-icu-data-dir.js b/test/parallel/test-icu-data-dir.js new file mode 100644 index 0000000000..07a4391505 --- /dev/null +++ b/test/parallel/test-icu-data-dir.js @@ -0,0 +1,19 @@ +'use strict'; +require('../common'); +const assert = require('assert'); +const { spawnSync } = require('child_process'); + +const expected = + 'could not initialize ICU ' + + '(check NODE_ICU_DATA or --icu-data-dir parameters)'; + +{ + const child = spawnSync(process.execPath, ['--icu-data-dir=/', '-e', '0']); + assert(child.stderr.toString().includes(expected)); +} + +{ + const env = { NODE_ICU_DATA: '/' }; + const child = spawnSync(process.execPath, ['-e', '0'], { env }); + assert(child.stderr.toString().includes(expected)); +} |