diff options
author | Daniel Bevenius <daniel.bevenius@gmail.com> | 2017-10-20 08:35:54 +0200 |
---|---|---|
committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2017-10-25 11:12:06 +0200 |
commit | 50d727587e1e6664ea690a3d1785e3b5c9849b65 (patch) | |
tree | 59e669dcb1c709df354ecdc43166eb4bfa81f954 /test/parallel/test-https-connect-address-family.js | |
parent | e70038528891aa7bddf44b39b85ee99ee30e6d6b (diff) | |
download | android-node-v8-50d727587e1e6664ea690a3d1785e3b5c9849b65.tar.gz android-node-v8-50d727587e1e6664ea690a3d1785e3b5c9849b65.tar.bz2 android-node-v8-50d727587e1e6664ea690a3d1785e3b5c9849b65.zip |
test: allow for different nsswitch.conf settings
The motivation for this commit is that these two test fail on systems
that have different Name Service Switch configuration settings. A
concrete example of this is when using Red Hat Enterprise Linux (RHEL)
7.
If Name Service Switch is available on the operating system then it
might be configured differently (/etc/nsswitch.conf).
If the system is configured with no dns the error code will be
AI_AGAIN, but if there are more services after the dns entry, for
example some linux distributions skip a myhostname service by default
which would still produce the ENOTFOUND error.
This commit suggests checking for either ENOTFOUND or EAI_AGAIN to
accommodate systems like the ones described above. The references below
indicate that others have run, or are running, into this aswell.
Refs: https://github.com/nodejs/node/issues/12075
Refs: https://github.com/nodejs/help/issues/687
Refs: https://github.com/nodejs/node/issues/15825
PR-URL: https://github.com/nodejs/node/pull/16378
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Diffstat (limited to 'test/parallel/test-https-connect-address-family.js')
-rw-r--r-- | test/parallel/test-https-connect-address-family.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/parallel/test-https-connect-address-family.js b/test/parallel/test-https-connect-address-family.js index fa9baa528e..a345a70a57 100644 --- a/test/parallel/test-https-connect-address-family.js +++ b/test/parallel/test-https-connect-address-family.js @@ -33,7 +33,7 @@ function runTest() { dns.lookup('localhost', { family: 6, all: true }, (err, addresses) => { if (err) { - if (err.code === 'ENOTFOUND') + if (err.code === 'ENOTFOUND' || err.code === 'EAI_AGAIN') common.skip('localhost does not resolve to ::1'); throw err; |