summaryrefslogtreecommitdiff
path: root/test/parallel/test-http2-util-asserts.js
diff options
context:
space:
mode:
authorRuben Bridgewater <ruben@bridgewater.de>2018-03-19 13:43:24 +0100
committerRuben Bridgewater <ruben@bridgewater.de>2018-03-25 01:45:38 +0100
commitc1278e53293a49c925451987d906f7b00977f4d4 (patch)
tree054adb3c03e66719b02377011cdf3f0de225a962 /test/parallel/test-http2-util-asserts.js
parentc6b6c92185316e13738e6fa931fdd5303e381e46 (diff)
downloadandroid-node-v8-c1278e53293a49c925451987d906f7b00977f4d4.tar.gz
android-node-v8-c1278e53293a49c925451987d906f7b00977f4d4.tar.bz2
android-node-v8-c1278e53293a49c925451987d906f7b00977f4d4.zip
lib,test: minor refactoring
This refactors a couple tests to have upper case first characters in comments and to use `input` instead of `i`. It also adds a few TODOs and rewrites a few lines to use default arguments and to prevent function recreation when unnecessary. PR-URL: https://github.com/nodejs/node/pull/19445 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'test/parallel/test-http2-util-asserts.js')
-rw-r--r--test/parallel/test-http2-util-asserts.js6
1 files changed, 3 insertions, 3 deletions
diff --git a/test/parallel/test-http2-util-asserts.js b/test/parallel/test-http2-util-asserts.js
index 3db74e2f2e..136c76cc04 100644
--- a/test/parallel/test-http2-util-asserts.js
+++ b/test/parallel/test-http2-util-asserts.js
@@ -13,8 +13,8 @@ const {
Object.create(null),
new Date(),
new (class Foo {})()
-].forEach((i) => {
- assertIsObject(i, 'foo', 'Object');
+].forEach((input) => {
+ assertIsObject(input, 'foo', 'Object');
});
[
@@ -39,5 +39,5 @@ assertWithinRange('foo', 1, 0, 2);
common.expectsError(() => assertWithinRange('foo', 1, 2, 3),
{
code: 'ERR_HTTP2_INVALID_SETTING_VALUE',
- message: /^Invalid value for setting "foo": 1$/
+ message: 'Invalid value for setting "foo": 1'
});