summaryrefslogtreecommitdiff
path: root/test/parallel/test-http2-socket-proxy.js
diff options
context:
space:
mode:
authorRuben Bridgewater <ruben@bridgewater.de>2018-02-09 02:32:04 +0100
committerRuben Bridgewater <ruben@bridgewater.de>2018-02-16 16:53:47 +0100
commitcaee112e52b64f4bc1118c4a5fa5ad7b4211efea (patch)
tree7b60b49da3f863917a23ebc94c00bf2f13cc1348 /test/parallel/test-http2-socket-proxy.js
parent4d3c3f039af08b954fbbba1e9a50979ffc98592b (diff)
downloadandroid-node-v8-caee112e52b64f4bc1118c4a5fa5ad7b4211efea.tar.gz
android-node-v8-caee112e52b64f4bc1118c4a5fa5ad7b4211efea.tar.bz2
android-node-v8-caee112e52b64f4bc1118c4a5fa5ad7b4211efea.zip
test: remove assert.doesNotThrow()
There is actually no reason to use `assert.doesNotThrow()` in the tests. If a test throws, just let the error bubble up right away instead of first catching it and then rethrowing it. PR-URL: https://github.com/nodejs/node/pull/18669 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'test/parallel/test-http2-socket-proxy.js')
-rw-r--r--test/parallel/test-http2-socket-proxy.js4
1 files changed, 2 insertions, 2 deletions
diff --git a/test/parallel/test-http2-socket-proxy.js b/test/parallel/test-http2-socket-proxy.js
index 1ca34eb451..751cacf8df 100644
--- a/test/parallel/test-http2-socket-proxy.js
+++ b/test/parallel/test-http2-socket-proxy.js
@@ -51,8 +51,8 @@ server.on('stream', common.mustCall(function(stream, headers) {
common.expectsError(() => (socket.resume = undefined), errMsg);
common.expectsError(() => (socket.write = undefined), errMsg);
- assert.doesNotThrow(() => (socket.on = socket.on));
- assert.doesNotThrow(() => (socket.once = socket.once));
+ socket.on = socket.on;
+ socket.once = socket.once;
stream.respond();