http2: cleanup Http2Stream/Http2Session destroy

PR-URL: https://github.com/nodejs/node/pull/17406
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

This is a significant cleanup and refactoring of the
cleanup/close/destroy logic for Http2Stream and Http2Session.
There are significant changes here in the timing and ordering
of cleanup logic, JS apis. and various related necessary edits.

1 files changed, 48 insertions, 0 deletions

diff --git a/test/parallel/test-http2-server-sessionerror.js b/test/parallel/test-http2-server-sessionerror.js
new file mode 100644
index 0000000000..525eb2e6ef
--- /dev/null
+++ b/test/parallel/test-http2-server-sessionerror.js
@@ -0,0 +1,48 @@
+// Flags: --expose-internals
+
+'use strict';
+
+const common = require('../common');
+if (!common.hasCrypto)
+  common.skip('missing crypto');
+const http2 = require('http2');
+const { kSocket } = require('internal/http2/util');
+
+const server = http2.createServer();
+server.on('stream', common.mustNotCall());
+
+let test = 0;
+
+server.on('session', common.mustCall((session) => {
+  switch (++test) {
+    case 1:
+      server.on('error', common.mustNotCall());
+      session.on('error', common.expectsError({
+        type: Error,
+        message: 'test'
+      }));
+      session[kSocket].emit('error', new Error('test'));
+      break;
+    case 2:
+      // If the server does not have a socketError listener,
+      // error will be silent on the server but will close
+      // the session
+      session[kSocket].emit('error', new Error('test'));
+      break;
+  }
+}, 2));
+
+server.listen(0, common.mustCall(() => {
+  const url = `http://localhost:${server.address().port}`;
+  http2.connect(url)
+    // An ECONNRESET error may occur depending on the platform (due largely
+    // to differences in the timing of socket closing). Do not wrap this in
+    // a common must call.
+    .on('error', () => {})
+    .on('close', () => {
+      server.removeAllListeners('error');
+      http2.connect(url)
+        .on('error', () => {})
+        .on('close', () => server.close());
+    });
+}));