test: remove assert.doesNotThrow()

There is actually no reason to use `assert.doesNotThrow()` in the
tests. If a test throws, just let the error bubble up right away
instead of first catching it and then rethrowing it.

PR-URL: https://github.com/nodejs/node/pull/18669
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

1 files changed, 11 insertions, 13 deletions

diff --git a/test/parallel/test-http2-connect.js b/test/parallel/test-http2-connect.js
index 894c51fe3d..9b628db5ae 100644
--- a/test/parallel/test-http2-connect.js
+++ b/test/parallel/test-http2-connect.js
@@ -3,7 +3,6 @@
 const { mustCall, hasCrypto, skip, expectsError } = require('../common');
 if (!hasCrypto)
   skip('missing crypto');
-const { doesNotThrow, throws } = require('assert');
 const { createServer, connect } = require('http2');
 {
   const server = createServer();
@@ -13,10 +12,11 @@ const { createServer, connect } = require('http2');
     const listener = () => mustCall();
 
     const clients = new Set();
-    doesNotThrow(() => clients.add(connect(authority)));
-    doesNotThrow(() => clients.add(connect(authority, options)));
-    doesNotThrow(() => clients.add(connect(authority, options, listener())));
-    doesNotThrow(() => clients.add(connect(authority, listener())));
+    // Should not throw.
+    clients.add(connect(authority));
+    clients.add(connect(authority, options));
+    clients.add(connect(authority, options, listener()));
+    clients.add(connect(authority, listener()));
 
     for (const client of clients) {
       client.once('connect', mustCall((headers) => {
@@ -33,20 +33,18 @@ const { createServer, connect } = require('http2');
 // check for https as protocol
 {
   const authority = 'https://localhost';
-  doesNotThrow(() => {
-    // A socket error may or may not be reported, keep this as a non-op
-    // instead of a mustCall or mustNotCall
-    connect(authority).on('error', () => {});
-  });
+  // A socket error may or may not be reported, keep this as a non-op
+  // instead of a mustCall or mustNotCall
+  connect(authority).on('error', () => {});
 }
 
 // check for error for an invalid protocol (not http or https)
 {
   const authority = 'ssh://localhost';
-  throws(() => {
+  expectsError(() => {
     connect(authority);
-  }, expectsError({
+  }, {
     code: 'ERR_HTTP2_UNSUPPORTED_PROTOCOL',
     type: Error
-  }));
+  });
 }