http2: destroy when settingsFn throws an error

http2.connect should call destroy when init fails.

PR-URL: https://github.com/nodejs/node/pull/28908
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

1 files changed, 14 insertions, 0 deletions

diff --git a/test/parallel/test-http2-connect.js b/test/parallel/test-http2-connect.js
index a1291e3be9..4569905eac 100644
--- a/test/parallel/test-http2-connect.js
+++ b/test/parallel/test-http2-connect.js
@@ -69,6 +69,20 @@ const { connect: netConnect } = require('net');
   connect(authority).on('error', () => {});
 }
 
+// Check for error for init settings error
+{
+  createServer(function() {
+    connect(`http://localhost:${this.address().port}`, {
+      settings: {
+        maxFrameSize: 1   // An incorrect settings
+      }
+    }).on('error', expectsError({
+      code: 'ERR_HTTP2_INVALID_SETTING_VALUE',
+      type: RangeError
+    }));
+  });
+}
+
 // Check for error for an invalid protocol (not http or https)
 {
   const authority = 'ssh://localhost';