diff options
author | Sebastiaan Deckers <sebdeckers83@gmail.com> | 2018-11-27 10:45:51 +0800 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2018-11-29 12:53:57 -0800 |
commit | 5dacbf594ef80f8eadea274f537cc17cc1e5ebe1 (patch) | |
tree | 1b865a406c369498a2f1c4255d8f9edadfb4919a /test/parallel/test-http2-compat-serverresponse-writehead-array.js | |
parent | 97fedefc18204e2c028cbca608a383075fcda7c7 (diff) | |
download | android-node-v8-5dacbf594ef80f8eadea274f537cc17cc1e5ebe1.tar.gz android-node-v8-5dacbf594ef80f8eadea274f537cc17cc1e5ebe1.tar.bz2 android-node-v8-5dacbf594ef80f8eadea274f537cc17cc1e5ebe1.zip |
http2: add compat support for nested array headers
writeHead supports an array of arrays containing header name and values.
Compatibility between http2 & http1 even though this is not documented.
Fixes: https://github.com/nodejs/node/issues/24466
PR-URL: https://github.com/nodejs/node/pull/24665
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Diffstat (limited to 'test/parallel/test-http2-compat-serverresponse-writehead-array.js')
-rw-r--r-- | test/parallel/test-http2-compat-serverresponse-writehead-array.js | 42 |
1 files changed, 42 insertions, 0 deletions
diff --git a/test/parallel/test-http2-compat-serverresponse-writehead-array.js b/test/parallel/test-http2-compat-serverresponse-writehead-array.js new file mode 100644 index 0000000000..e024f8ab39 --- /dev/null +++ b/test/parallel/test-http2-compat-serverresponse-writehead-array.js @@ -0,0 +1,42 @@ +'use strict'; + +const common = require('../common'); +if (!common.hasCrypto) + common.skip('missing crypto'); +const assert = require('assert'); +const h2 = require('http2'); + +// Http2ServerResponse.writeHead should support nested arrays + +const server = h2.createServer(); +server.listen(0, common.mustCall(() => { + const port = server.address().port; + server.once('request', common.mustCall((request, response) => { + response.writeHead(200, [ + ['foo', 'bar'], + ['ABC', 123] + ]); + response.end(common.mustCall(() => { server.close(); })); + })); + + const url = `http://localhost:${port}`; + const client = h2.connect(url, common.mustCall(() => { + const headers = { + ':path': '/', + ':method': 'GET', + ':scheme': 'http', + ':authority': `localhost:${port}` + }; + const request = client.request(headers); + request.on('response', common.mustCall((headers) => { + assert.strictEqual(headers.foo, 'bar'); + assert.strictEqual(headers.abc, '123'); + assert.strictEqual(headers[':status'], 200); + }, 1)); + request.on('end', common.mustCall(() => { + client.close(); + })); + request.end(); + request.resume(); + })); +})); |