http2: cleanup Http2Stream/Http2Session destroy

PR-URL: https://github.com/nodejs/node/pull/17406
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

This is a significant cleanup and refactoring of the
cleanup/close/destroy logic for Http2Stream and Http2Session.
There are significant changes here in the timing and ordering
of cleanup logic, JS apis. and various related necessary edits.

1 files changed, 3 insertions, 14 deletions

diff --git a/test/parallel/test-http2-compat-expect-continue.js b/test/parallel/test-http2-compat-expect-continue.js
index 6f08e813ef..42fa80ae4e 100644
--- a/test/parallel/test-http2-compat-expect-continue.js
+++ b/test/parallel/test-http2-compat-expect-continue.js
@@ -17,8 +17,6 @@ const server = http2.createServer();
 let sentResponse = false;
 
 server.on('request', common.mustCall((req, res) => {
-  console.error('Server sent full response');
-
   res.end(testResBody);
   sentResponse = true;
 }));
@@ -28,38 +26,29 @@ server.listen(0);
 server.on('listening', common.mustCall(() => {
   let body = '';
 
-  const port = server.address().port;
-  const client = http2.connect(`http://localhost:${port}`);
+  const client = http2.connect(`http://localhost:${server.address().port}`);
   const req = client.request({
     ':method': 'POST',
-    ':path': '/world',
     expect: '100-continue'
   });
-  console.error('Client sent request');
 
   let gotContinue = false;
   req.on('continue', common.mustCall(() => {
-    console.error('Client received 100-continue');
     gotContinue = true;
   }));
 
   req.on('response', common.mustCall((headers) => {
-    console.error('Client received response headers');
-
     assert.strictEqual(gotContinue, true);
     assert.strictEqual(sentResponse, true);
     assert.strictEqual(headers[':status'], 200);
+    req.end();
   }));
 
   req.setEncoding('utf8');
   req.on('data', common.mustCall((chunk) => { body += chunk; }));
-
   req.on('end', common.mustCall(() => {
-    console.error('Client received full response');
-
     assert.strictEqual(body, testResBody);
-
-    client.destroy();
+    client.close();
     server.close();
   }));
 }));