diff options
author | Trivikram <16024985+trivikr@users.noreply.github.com> | 2018-02-28 20:48:29 +0530 |
---|---|---|
committer | Anatoli Papirovski <apapirovski@mac.com> | 2018-03-04 13:23:34 +0100 |
commit | caaf7e3a9f119e8fec1018ea835210b50c6d47f7 (patch) | |
tree | b972389ce092710f5b0e21f39ddc4f285d7af330 /test/parallel/test-http2-client-rststream-before-connect.js | |
parent | cb94bf01aae1802d7d7858a806ef8a82dd4b65f9 (diff) | |
download | android-node-v8-caaf7e3a9f119e8fec1018ea835210b50c6d47f7.tar.gz android-node-v8-caaf7e3a9f119e8fec1018ea835210b50c6d47f7.tar.bz2 android-node-v8-caaf7e3a9f119e8fec1018ea835210b50c6d47f7.zip |
http2: callback valid check before closing request
Do not close the request if callback is not a function, and
throw ERR_INVALID_CALLBACK TypeError
PR-URL: https://github.com/nodejs/node/pull/19061
Fixes: https://github.com/nodejs/node/issues/18855
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Diffstat (limited to 'test/parallel/test-http2-client-rststream-before-connect.js')
-rw-r--r-- | test/parallel/test-http2-client-rststream-before-connect.js | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/test/parallel/test-http2-client-rststream-before-connect.js b/test/parallel/test-http2-client-rststream-before-connect.js index 01e0561c3a..8ed91e3f03 100644 --- a/test/parallel/test-http2-client-rststream-before-connect.js +++ b/test/parallel/test-http2-client-rststream-before-connect.js @@ -28,6 +28,18 @@ server.listen(0, common.mustCall(() => { ); assert.strictEqual(req.closed, false); + [true, 1, {}, [], null, 'test'].forEach((notFunction) => { + common.expectsError( + () => req.close(closeCode, notFunction), + { + type: TypeError, + code: 'ERR_INVALID_CALLBACK', + message: 'Callback must be a function' + } + ); + assert.strictEqual(req.closed, false); + }); + req.close(closeCode, common.mustCall()); assert.strictEqual(req.closed, true); |