diff options
author | Anatoli Papirovski <apapirovski@mac.com> | 2017-11-04 13:42:07 -0400 |
---|---|---|
committer | Anatoli Papirovski <apapirovski@mac.com> | 2017-11-07 12:20:50 -0500 |
commit | 795a96400613c11791d6b2609811e6c7e48661ef (patch) | |
tree | bfe9cd4060ee5d8a58ad22277cacd9d7ee63aaed /test/parallel/test-http2-client-rststream-before-connect.js | |
parent | daeb7a64a5c4516052d0a0bd3ae77749ed02afbb (diff) | |
download | android-node-v8-795a96400613c11791d6b2609811e6c7e48661ef.tar.gz android-node-v8-795a96400613c11791d6b2609811e6c7e48661ef.tar.bz2 android-node-v8-795a96400613c11791d6b2609811e6c7e48661ef.zip |
http2: simplify subsequent rstStream calls
Do not call destroy each time rstStream is called since the
first call (or receipt of rst frame) will always trigger
destroy. Expand existing test for this behaviour.
PR-URL: https://github.com/nodejs/node/pull/16753
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/parallel/test-http2-client-rststream-before-connect.js')
-rw-r--r-- | test/parallel/test-http2-client-rststream-before-connect.js | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/test/parallel/test-http2-client-rststream-before-connect.js b/test/parallel/test-http2-client-rststream-before-connect.js index 073b2d4837..3c4ac3b34d 100644 --- a/test/parallel/test-http2-client-rststream-before-connect.js +++ b/test/parallel/test-http2-client-rststream-before-connect.js @@ -21,6 +21,10 @@ server.on('listening', common.mustCall(() => { // make sure that destroy is called req._destroy = common.mustCall(req._destroy.bind(req)); + // second call doesn't do anything + assert.doesNotThrow(() => client.rstStream(req, 8)); + assert.strictEqual(req.rstCode, 0); + req.on('streamClosed', common.mustCall((code) => { assert.strictEqual(req.destroyed, true); assert.strictEqual(code, 0); |