summaryrefslogtreecommitdiff
path: root/test/parallel/test-http-writable-true-after-close.js
diff options
context:
space:
mode:
authorRich Trott <rtrott@gmail.com>2017-09-30 17:33:28 -0700
committerRuben Bridgewater <ruben@bridgewater.de>2017-10-01 19:44:48 -0300
commitee90959071e2d9f41b1cebe631aebaf25724600a (patch)
tree7c0ae6ea6ce7f4bd5bce2163c0712b80fda1a3f9 /test/parallel/test-http-writable-true-after-close.js
parentf9be5fe52a5d3db90fac28a2fa8c62e1388dc9cd (diff)
downloadandroid-node-v8-ee90959071e2d9f41b1cebe631aebaf25724600a.tar.gz
android-node-v8-ee90959071e2d9f41b1cebe631aebaf25724600a.tar.bz2
android-node-v8-ee90959071e2d9f41b1cebe631aebaf25724600a.zip
test: fix test-https-writable-true-after-close
test-https-writable-true-after-close fails intermittently when run with a lot of competing processes. Move it to sequential for stability. PR-URL: https://github.com/nodejs/node/pull/15705 Fixes: https://github.com/nodejs/node/issues/15700 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Diffstat (limited to 'test/parallel/test-http-writable-true-after-close.js')
-rw-r--r--test/parallel/test-http-writable-true-after-close.js42
1 files changed, 0 insertions, 42 deletions
diff --git a/test/parallel/test-http-writable-true-after-close.js b/test/parallel/test-http-writable-true-after-close.js
deleted file mode 100644
index 49688a00ef..0000000000
--- a/test/parallel/test-http-writable-true-after-close.js
+++ /dev/null
@@ -1,42 +0,0 @@
-'use strict';
-
-const common = require('../common');
-const assert = require('assert');
-const { get, createServer } = require('http');
-
-// res.writable should not be set to false after it has finished sending
-// Ref: https://github.com/nodejs/node/issues/15029
-
-let internal;
-let external;
-
-// Proxy server
-const server = createServer(common.mustCall((req, res) => {
- get(`http://127.0.0.1:${internal.address().port}`, common.mustCall((inner) => {
- const listener = common.mustCall(() => {
- assert.strictEqual(res.writable, true);
- });
-
- // on CentOS 5, 'finish' is emitted
- res.on('finish', listener);
- // everywhere else, 'close' is emitted
- res.on('close', listener);
-
- inner.pipe(res);
- }));
-})).listen(0, () => {
- // Http server
- internal = createServer((req, res) => {
- res.writeHead(200);
- setImmediate(common.mustCall(() => {
- external.abort();
- res.end('Hello World\n');
- }));
- }).listen(0, () => {
- external = get(`http://127.0.0.1:${server.address().port}`);
- external.on('error', common.mustCall((err) => {
- server.close();
- internal.close();
- }));
- });
-});