diff options
author | James M Snell <jasnell@gmail.com> | 2017-03-24 09:46:44 -0700 |
---|---|---|
committer | James M Snell <jasnell@gmail.com> | 2017-03-26 12:47:15 -0700 |
commit | 4f2e372716714ed030cb5ba6e67107b913f15343 (patch) | |
tree | 9b86be4f904c7844c48cca4194f3c3a5a1decad8 /test/parallel/test-http-upgrade-server.js | |
parent | d13bd4acc0b60191f0d6e9fae92087242d04dfbd (diff) | |
download | android-node-v8-4f2e372716714ed030cb5ba6e67107b913f15343.tar.gz android-node-v8-4f2e372716714ed030cb5ba6e67107b913f15343.tar.bz2 android-node-v8-4f2e372716714ed030cb5ba6e67107b913f15343.zip |
test: add common.noop, default for common.mustCall()
Export a new common.noop no-operation function for general use.
Allow using common.mustCall() without a fn argument to simplify
test cases.
Replace various non-op functions throughout tests with common.noop
PR-URL: https://github.com/nodejs/node/pull/12027
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Diffstat (limited to 'test/parallel/test-http-upgrade-server.js')
-rw-r--r-- | test/parallel/test-http-upgrade-server.js | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/test/parallel/test-http-upgrade-server.js b/test/parallel/test-http-upgrade-server.js index a573e3ca52..11c0aba5b4 100644 --- a/test/parallel/test-http-upgrade-server.js +++ b/test/parallel/test-http-upgrade-server.js @@ -20,7 +20,8 @@ // USE OR OTHER DEALINGS IN THE SOFTWARE. 'use strict'; -require('../common'); + +const common = require('../common'); const assert = require('assert'); const util = require('util'); @@ -37,7 +38,7 @@ function createTestServer() { } function testServer() { - http.Server.call(this, function() {}); + http.Server.call(this, common.noop); this.on('connection', function() { requests_recv++; |