diff options
author | Brian White <mscdex@mscdex.net> | 2016-05-29 03:06:56 -0400 |
---|---|---|
committer | Brian White <mscdex@mscdex.net> | 2016-06-10 22:30:55 -0400 |
commit | 2bc7841d0fcdd066fe477873229125b6f003b693 (patch) | |
tree | 2816555ef6ad2fc828a75dc3c564f8faa2dee6c7 /test/parallel/test-http-should-keep-alive.js | |
parent | 624734e640717a826ab1a18845c083a638dc5ce6 (diff) | |
download | android-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.tar.gz android-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.tar.bz2 android-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.zip |
test: use random ports where possible
This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.
PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Diffstat (limited to 'test/parallel/test-http-should-keep-alive.js')
-rw-r--r-- | test/parallel/test-http-should-keep-alive.js | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/test/parallel/test-http-should-keep-alive.js b/test/parallel/test-http-should-keep-alive.js index 870223a37b..3aaa2d3d73 100644 --- a/test/parallel/test-http-should-keep-alive.js +++ b/test/parallel/test-http-should-keep-alive.js @@ -1,5 +1,5 @@ 'use strict'; -var common = require('../common'); +require('../common'); var assert = require('assert'); var http = require('http'); var net = require('net'); @@ -27,9 +27,9 @@ http.globalAgent.maxSockets = 5; var server = net.createServer(function(socket) { socket.write(SERVER_RESPONSES[requests]); ++requests; -}).listen(common.PORT, function() { +}).listen(0, function() { function makeRequest() { - var req = http.get({port: common.PORT}, function(res) { + var req = http.get({port: server.address().port}, function(res) { assert.equal(req.shouldKeepAlive, SHOULD_KEEP_ALIVE[responses], SERVER_RESPONSES[responses] + ' should ' + (SHOULD_KEEP_ALIVE[responses] ? '' : 'not ') + |