summaryrefslogtreecommitdiff
path: root/test/parallel/test-http-set-cookies.js
diff options
context:
space:
mode:
authorBrian White <mscdex@mscdex.net>2016-05-29 03:06:56 -0400
committerBrian White <mscdex@mscdex.net>2016-06-10 22:30:55 -0400
commit2bc7841d0fcdd066fe477873229125b6f003b693 (patch)
tree2816555ef6ad2fc828a75dc3c564f8faa2dee6c7 /test/parallel/test-http-set-cookies.js
parent624734e640717a826ab1a18845c083a638dc5ce6 (diff)
downloadandroid-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.tar.gz
android-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.tar.bz2
android-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.zip
test: use random ports where possible
This helps to prevent issues where a failed test can keep a bound socket open long enough to cause other tests to fail with EADDRINUSE because the same port number is used. PR-URL: https://github.com/nodejs/node/pull/7045 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Diffstat (limited to 'test/parallel/test-http-set-cookies.js')
-rw-r--r--test/parallel/test-http-set-cookies.js8
1 files changed, 4 insertions, 4 deletions
diff --git a/test/parallel/test-http-set-cookies.js b/test/parallel/test-http-set-cookies.js
index 061f45fdac..8707267dda 100644
--- a/test/parallel/test-http-set-cookies.js
+++ b/test/parallel/test-http-set-cookies.js
@@ -1,5 +1,5 @@
'use strict';
-var common = require('../common');
+require('../common');
var assert = require('assert');
var http = require('http');
@@ -17,13 +17,13 @@ var server = http.createServer(function(req, res) {
res.end('two\n');
}
});
-server.listen(common.PORT);
+server.listen(0);
server.on('listening', function() {
//
// one set-cookie header
//
- http.get({ port: common.PORT, path: '/one' }, function(res) {
+ http.get({ port: this.address().port, path: '/one' }, function(res) {
// set-cookie headers are always return in an array.
// even if there is only one.
assert.deepStrictEqual(['A'], res.headers['set-cookie']);
@@ -42,7 +42,7 @@ server.on('listening', function() {
// two set-cookie headers
- http.get({ port: common.PORT, path: '/two' }, function(res) {
+ http.get({ port: this.address().port, path: '/two' }, function(res) {
assert.deepStrictEqual(['A', 'B'], res.headers['set-cookie']);
assert.equal('text/plain', res.headers['content-type']);