test: add common.mustNotCall()

This commit adds a mustNotCall() helper for testing. This provides
an alternative to using common.fail() as a callback, or creating
a callback function for the sole purpose of calling common.fail().

PR-URL: https://github.com/nodejs/node/pull/11152
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

1 files changed, 2 insertions, 6 deletions

diff --git a/test/parallel/test-http-server-reject-cr-no-lf.js b/test/parallel/test-http-server-reject-cr-no-lf.js
index 73508cf08e..9821715037 100644
--- a/test/parallel/test-http-server-reject-cr-no-lf.js
+++ b/test/parallel/test-http-server-reject-cr-no-lf.js
@@ -11,9 +11,7 @@ const str = 'GET / HTTP/1.1\r\n' +
             '\r\n';
 
 
-const server = http.createServer((req, res) => {
-  common.fail('this should not be called');
-});
+const server = http.createServer(common.mustNotCall());
 server.on('clientError', common.mustCall((err) => {
   assert(/^Parse Error/.test(err.message));
   assert.strictEqual(err.code, 'HPE_LF_EXPECTED');
@@ -21,9 +19,7 @@ server.on('clientError', common.mustCall((err) => {
 }));
 server.listen(0, () => {
   const client = net.connect({port: server.address().port}, () => {
-    client.on('data', (chunk) => {
-      common.fail('this should not be called');
-    });
+    client.on('data', common.mustNotCall());
     client.on('end', common.mustCall(() => {
       server.close();
     }));