diff options
| author | Rich Trott <rtrott@gmail.com> | 2019-08-27 23:04:51 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-08-30 07:16:19 -0700 |
| commit | 9e52654fd4bc8f8009effb0b391a2508612405ad (patch) | |
| tree | 0dcc1b97c2ecd17f313f328bbd90dbedb97392dc /test/parallel/test-http-server-keepalive-req-gc.js | |
| parent | 8f33053dbfc4078812f6b4b551cc9a2e6964b985 (diff) | |
| download | android-node-v8-9e52654fd4bc8f8009effb0b391a2508612405ad.tar.gz android-node-v8-9e52654fd4bc8f8009effb0b391a2508612405ad.tar.bz2 android-node-v8-9e52654fd4bc8f8009effb0b391a2508612405ad.zip | |
test: remove Windows skipping of http keepalive request GC test
Remove code to skip Windows in test-http-server-keepalive-req-gc. The
test now works reliably on Windows (I think).
PR-URL: https://github.com/nodejs/node/pull/29354
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Diffstat (limited to 'test/parallel/test-http-server-keepalive-req-gc.js')
| -rw-r--r-- | test/parallel/test-http-server-keepalive-req-gc.js | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/test/parallel/test-http-server-keepalive-req-gc.js b/test/parallel/test-http-server-keepalive-req-gc.js index 77defb5154..e94845d38d 100644 --- a/test/parallel/test-http-server-keepalive-req-gc.js +++ b/test/parallel/test-http-server-keepalive-req-gc.js @@ -5,11 +5,6 @@ const onGC = require('../common/ongc'); const { createServer } = require('http'); const { connect } = require('net'); -if (common.isWindows) { - // TODO(addaleax): Investigate why and remove the skip. - common.skip('This test is flaky on Windows.'); -} - // Make sure that for HTTP keepalive requests, the req object can be // garbage collected once the request is finished. // Refs: https://github.com/nodejs/node/issues/9668 |