diff options
author | Luigi Pinca <luigipinca@gmail.com> | 2018-11-30 19:27:26 +0100 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2018-12-03 18:02:40 -0800 |
commit | ff7d053ae6b7f620516049e5c9bd1b6ab348835f (patch) | |
tree | 2ed68223fa41758d355552cb59953c8b0235a342 /test/parallel/test-http-server-destroy-socket-on-client-error.js | |
parent | 9159fb733cfc7858ab59558db12686a5f13baaf1 (diff) | |
download | android-node-v8-ff7d053ae6b7f620516049e5c9bd1b6ab348835f.tar.gz android-node-v8-ff7d053ae6b7f620516049e5c9bd1b6ab348835f.tar.bz2 android-node-v8-ff7d053ae6b7f620516049e5c9bd1b6ab348835f.zip |
http: destroy the socket on parse error
Destroy the socket if the `'clientError'` event is emitted and there is
no listener for it.
Fixes: https://github.com/nodejs/node/issues/24586
PR-URL: https://github.com/nodejs/node/pull/24757
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'test/parallel/test-http-server-destroy-socket-on-client-error.js')
-rw-r--r-- | test/parallel/test-http-server-destroy-socket-on-client-error.js | 45 |
1 files changed, 45 insertions, 0 deletions
diff --git a/test/parallel/test-http-server-destroy-socket-on-client-error.js b/test/parallel/test-http-server-destroy-socket-on-client-error.js new file mode 100644 index 0000000000..9d51364183 --- /dev/null +++ b/test/parallel/test-http-server-destroy-socket-on-client-error.js @@ -0,0 +1,45 @@ +'use strict'; + +const { expectsError, mustCall } = require('../common'); + +// Test that the request socket is destroyed if the `'clientError'` event is +// emitted and there is no listener for it. + +const assert = require('assert'); +const { createServer } = require('http'); +const { createConnection } = require('net'); + +const server = createServer(); + +server.on('connection', mustCall((socket) => { + socket.on('error', expectsError({ + type: Error, + message: 'Parse Error', + code: 'HPE_INVALID_METHOD', + bytesParsed: 0, + rawPacket: Buffer.from('FOO /\r\n') + })); +})); + +server.listen(0, () => { + const chunks = []; + const socket = createConnection({ + allowHalfOpen: true, + port: server.address().port + }); + + socket.on('connect', mustCall(() => { + socket.write('FOO /\r\n'); + })); + + socket.on('data', (chunk) => { + chunks.push(chunk); + }); + + socket.on('end', mustCall(() => { + const expected = Buffer.from('HTTP/1.1 400 Bad Request\r\n\r\n'); + assert(Buffer.concat(chunks).equals(expected)); + + server.close(); + })); +}); |