test: use random ports where possible

This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.

PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

1 files changed, 6 insertions, 3 deletions

diff --git a/test/parallel/test-http-response-status-message.js b/test/parallel/test-http-response-status-message.js
index a1e1f15697..b14c1f2faf 100644
--- a/test/parallel/test-http-response-status-message.js
+++ b/test/parallel/test-http-response-status-message.js
@@ -1,5 +1,5 @@
 'use strict';
-var common = require('../common');
+require('../common');
 var assert = require('assert');
 var http = require('http');
 var net = require('net');
@@ -41,7 +41,10 @@ var server = net.createServer(function(connection) {
 var runTest = function(testCaseIndex) {
   var testCase = testCases[testCaseIndex];
 
-  http.get({ port: common.PORT, path: testCase.path }, function(response) {
+  http.get({
+    port: server.address().port,
+    path: testCase.path
+  }, function(response) {
     console.log('client: expected status message: ' + testCase.statusMessage);
     console.log('client: actual status message: ' + response.statusMessage);
     assert.equal(testCase.statusMessage, response.statusMessage);
@@ -60,7 +63,7 @@ var runTest = function(testCaseIndex) {
   });
 };
 
-server.listen(common.PORT, function() { runTest(0); });
+server.listen(0, function() { runTest(0); });
 
 process.on('exit', function() {
   assert.equal(testCases.length, testsComplete);