diff options
author | Brian White <mscdex@mscdex.net> | 2016-05-29 03:06:56 -0400 |
---|---|---|
committer | Brian White <mscdex@mscdex.net> | 2016-06-10 22:30:55 -0400 |
commit | 2bc7841d0fcdd066fe477873229125b6f003b693 (patch) | |
tree | 2816555ef6ad2fc828a75dc3c564f8faa2dee6c7 /test/parallel/test-http-request-methods.js | |
parent | 624734e640717a826ab1a18845c083a638dc5ce6 (diff) | |
download | android-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.tar.gz android-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.tar.bz2 android-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.zip |
test: use random ports where possible
This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.
PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Diffstat (limited to 'test/parallel/test-http-request-methods.js')
-rw-r--r-- | test/parallel/test-http-request-methods.js | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/test/parallel/test-http-request-methods.js b/test/parallel/test-http-request-methods.js index b29a6663ff..cbfbbbc2ed 100644 --- a/test/parallel/test-http-request-methods.js +++ b/test/parallel/test-http-request-methods.js @@ -1,5 +1,5 @@ 'use strict'; -var common = require('../common'); +require('../common'); var assert = require('assert'); var net = require('net'); var http = require('http'); @@ -7,8 +7,6 @@ var http = require('http'); // Test that the DELETE, PATCH and PURGE verbs get passed through correctly ['DELETE', 'PATCH', 'PURGE'].forEach(function(method, index) { - var port = common.PORT + index; - var server_response = ''; var received_method = null; @@ -19,10 +17,10 @@ var http = require('http'); res.write('world\n'); res.end(); }); - server.listen(port); + server.listen(0); server.on('listening', function() { - var c = net.createConnection(port); + var c = net.createConnection(this.address().port); c.setEncoding('utf8'); |