test: use random ports where possible

This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.

PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

1 files changed, 33 insertions, 32 deletions

diff --git a/test/parallel/test-http-request-dont-override-options.js b/test/parallel/test-http-request-dont-override-options.js
index 66d82caeac..fd7c7b4e99 100644
--- a/test/parallel/test-http-request-dont-override-options.js
+++ b/test/parallel/test-http-request-dont-override-options.js
@@ -11,35 +11,36 @@ http.createServer(function(req, res) {
   res.end('ok');
 
   requests++;
-}).listen(common.PORT).unref();
-
-var agent = new http.Agent();
-agent.defaultPort = common.PORT;
-
-// options marked as explicitly undefined for readability
-// in this test, they should STAY undefined as options should not
-// be mutable / modified
-var options = {
-  host: undefined,
-  hostname: common.localhostIPv4,
-  port: undefined,
-  defaultPort: undefined,
-  path: undefined,
-  method: undefined,
-  agent: agent
-};
-
-http.request(options, function(res) {
-  res.resume();
-}).end();
-
-process.on('exit', function() {
-  assert.equal(requests, 1);
-
-  assert.strictEqual(options.host, undefined);
-  assert.strictEqual(options.hostname, common.localhostIPv4);
-  assert.strictEqual(options.port, undefined);
-  assert.strictEqual(options.defaultPort, undefined);
-  assert.strictEqual(options.path, undefined);
-  assert.strictEqual(options.method, undefined);
-});
+}).listen(0, function() {
+  var agent = new http.Agent();
+  agent.defaultPort = this.address().port;
+
+  // options marked as explicitly undefined for readability
+  // in this test, they should STAY undefined as options should not
+  // be mutable / modified
+  var options = {
+    host: undefined,
+    hostname: common.localhostIPv4,
+    port: undefined,
+    defaultPort: undefined,
+    path: undefined,
+    method: undefined,
+    agent: agent
+  };
+
+  http.request(options, function(res) {
+    res.resume();
+  }).end();
+
+  process.on('exit', function() {
+    assert.equal(requests, 1);
+
+    assert.strictEqual(options.host, undefined);
+    assert.strictEqual(options.hostname, common.localhostIPv4);
+    assert.strictEqual(options.port, undefined);
+    assert.strictEqual(options.defaultPort, undefined);
+    assert.strictEqual(options.path, undefined);
+    assert.strictEqual(options.method, undefined);
+  });
+}).unref();
+