diff options
author | Brian White <mscdex@mscdex.net> | 2016-05-29 03:06:56 -0400 |
---|---|---|
committer | Brian White <mscdex@mscdex.net> | 2016-06-10 22:30:55 -0400 |
commit | 2bc7841d0fcdd066fe477873229125b6f003b693 (patch) | |
tree | 2816555ef6ad2fc828a75dc3c564f8faa2dee6c7 /test/parallel/test-http-raw-headers.js | |
parent | 624734e640717a826ab1a18845c083a638dc5ce6 (diff) | |
download | android-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.tar.gz android-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.tar.bz2 android-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.zip |
test: use random ports where possible
This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.
PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Diffstat (limited to 'test/parallel/test-http-raw-headers.js')
-rw-r--r-- | test/parallel/test-http-raw-headers.js | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/test/parallel/test-http-raw-headers.js b/test/parallel/test-http-raw-headers.js index 22be129ec9..2e2e963149 100644 --- a/test/parallel/test-http-raw-headers.js +++ b/test/parallel/test-http-raw-headers.js @@ -1,14 +1,13 @@ 'use strict'; -var common = require('../common'); +require('../common'); var assert = require('assert'); var http = require('http'); http.createServer(function(req, res) { - this.close(); var expectRawHeaders = [ 'Host', - 'localhost:' + common.PORT, + `localhost:${this.address().port}`, 'transfer-ENCODING', 'CHUNKED', 'x-BaR', @@ -17,12 +16,11 @@ http.createServer(function(req, res) { 'close' ]; var expectHeaders = { - host: 'localhost:' + common.PORT, + host: `localhost:${this.address().port}`, 'transfer-encoding': 'CHUNKED', 'x-bar': 'yoyoyo', connection: 'close' }; - var expectRawTrailers = [ 'x-bAr', 'yOyOyOy', @@ -33,9 +31,10 @@ http.createServer(function(req, res) { 'X-baR', 'OyOyOyO' ]; - var expectTrailers = { 'x-bar': 'yOyOyOy, OyOyOyO, yOyOyOy, OyOyOyO' }; + this.close(); + assert.deepStrictEqual(req.rawHeaders, expectRawHeaders); assert.deepStrictEqual(req.headers, expectHeaders); @@ -53,8 +52,8 @@ http.createServer(function(req, res) { ['X-foO', 'OxOxOxO'] ]); res.end('x f o o'); -}).listen(common.PORT, function() { - var req = http.request({ port: common.PORT, path: '/' }); +}).listen(0, function() { + var req = http.request({ port: this.address().port, path: '/' }); req.addTrailers([ ['x-bAr', 'yOyOyOy'], ['x-baR', 'OyOyOyO'], |