diff options
author | Brian White <mscdex@mscdex.net> | 2016-05-29 03:06:56 -0400 |
---|---|---|
committer | Brian White <mscdex@mscdex.net> | 2016-06-10 22:30:55 -0400 |
commit | 2bc7841d0fcdd066fe477873229125b6f003b693 (patch) | |
tree | 2816555ef6ad2fc828a75dc3c564f8faa2dee6c7 /test/parallel/test-http-invalidheaderfield.js | |
parent | 624734e640717a826ab1a18845c083a638dc5ce6 (diff) | |
download | android-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.tar.gz android-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.tar.bz2 android-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.zip |
test: use random ports where possible
This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.
PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Diffstat (limited to 'test/parallel/test-http-invalidheaderfield.js')
-rw-r--r-- | test/parallel/test-http-invalidheaderfield.js | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/test/parallel/test-http-invalidheaderfield.js b/test/parallel/test-http-invalidheaderfield.js index 7e130e50d8..9d4a12a952 100644 --- a/test/parallel/test-http-invalidheaderfield.js +++ b/test/parallel/test-http-invalidheaderfield.js @@ -1,5 +1,5 @@ 'use strict'; -const common = require('../common'); +require('../common'); const assert = require('assert'); const EventEmitter = require('events'); const http = require('http'); @@ -16,16 +16,16 @@ const server = http.createServer(function(req, res) { }, TypeError); res.end(''); }); -server.listen(common.PORT, function() { +server.listen(0, function() { - http.get({port: common.PORT}, function() { + http.get({port: this.address().port}, function() { ee.emit('done'); }); assert.throws( function() { var options = { - port: common.PORT, + port: server.address().port, headers: {'testing 123': 123} }; http.get(options, function() {}); @@ -39,7 +39,7 @@ server.listen(common.PORT, function() { assert.doesNotThrow( function() { var options = { - port: common.PORT, + port: server.address().port, headers: {'testing_123': 123} }; http.get(options, function() { |