aboutsummaryrefslogtreecommitdiff
path: root/test/parallel/test-http-incoming-pipelined-socket-destroy.js
diff options
context:
space:
mode:
authorBrian White <mscdex@mscdex.net>2016-05-29 03:06:56 -0400
committerBrian White <mscdex@mscdex.net>2016-06-10 22:30:55 -0400
commit2bc7841d0fcdd066fe477873229125b6f003b693 (patch)
tree2816555ef6ad2fc828a75dc3c564f8faa2dee6c7 /test/parallel/test-http-incoming-pipelined-socket-destroy.js
parent624734e640717a826ab1a18845c083a638dc5ce6 (diff)
downloadandroid-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.tar.gz
android-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.tar.bz2
android-node-v8-2bc7841d0fcdd066fe477873229125b6f003b693.zip
test: use random ports where possible
This helps to prevent issues where a failed test can keep a bound socket open long enough to cause other tests to fail with EADDRINUSE because the same port number is used. PR-URL: https://github.com/nodejs/node/pull/7045 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Diffstat (limited to 'test/parallel/test-http-incoming-pipelined-socket-destroy.js')
-rw-r--r--test/parallel/test-http-incoming-pipelined-socket-destroy.js8
1 files changed, 4 insertions, 4 deletions
diff --git a/test/parallel/test-http-incoming-pipelined-socket-destroy.js b/test/parallel/test-http-incoming-pipelined-socket-destroy.js
index 1e5a910424..0cb29610f1 100644
--- a/test/parallel/test-http-incoming-pipelined-socket-destroy.js
+++ b/test/parallel/test-http-incoming-pipelined-socket-destroy.js
@@ -1,5 +1,5 @@
'use strict';
-var common = require('../common');
+require('../common');
var http = require('http');
var net = require('net');
@@ -40,16 +40,16 @@ var server = http.createServer(function(req, res) {
function generator(seeds) {
return seeds.map(function(r) {
return 'GET /' + r + ' HTTP/1.1\r\n' +
- 'Host: localhost:' + common.PORT + '\r\n' +
+ `Host: localhost:${server.address().port}\r\n` +
'\r\n' +
'\r\n';
}).join('');
}
-server.listen(common.PORT, function() {
+server.listen(0, function() {
var seeds = [ 3, 1, 2, 3, 4, 1, 2, 3, 4, 1, 2, 3, 4 ];
- var client = net.connect({ port: common.PORT });
+ var client = net.connect({ port: this.address().port });
var done = 0;
server.on('requestDone', function() {
if (++done == seeds.length) {