diff options
author | Ruben Bridgewater <ruben@bridgewater.de> | 2018-02-09 02:32:04 +0100 |
---|---|---|
committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-02-16 16:53:47 +0100 |
commit | caee112e52b64f4bc1118c4a5fa5ad7b4211efea (patch) | |
tree | 7b60b49da3f863917a23ebc94c00bf2f13cc1348 /test/parallel/test-http-hostname-typechecking.js | |
parent | 4d3c3f039af08b954fbbba1e9a50979ffc98592b (diff) | |
download | android-node-v8-caee112e52b64f4bc1118c4a5fa5ad7b4211efea.tar.gz android-node-v8-caee112e52b64f4bc1118c4a5fa5ad7b4211efea.tar.bz2 android-node-v8-caee112e52b64f4bc1118c4a5fa5ad7b4211efea.zip |
test: remove assert.doesNotThrow()
There is actually no reason to use `assert.doesNotThrow()` in the
tests. If a test throws, just let the error bubble up right away
instead of first catching it and then rethrowing it.
PR-URL: https://github.com/nodejs/node/pull/18669
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'test/parallel/test-http-hostname-typechecking.js')
-rw-r--r-- | test/parallel/test-http-hostname-typechecking.js | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/test/parallel/test-http-hostname-typechecking.js b/test/parallel/test-http-hostname-typechecking.js index 12fe72005a..72440391fa 100644 --- a/test/parallel/test-http-hostname-typechecking.js +++ b/test/parallel/test-http-hostname-typechecking.js @@ -1,7 +1,6 @@ 'use strict'; const common = require('../common'); -const assert = require('assert'); const http = require('http'); // All of these values should cause http.request() to throw synchronously @@ -36,8 +35,6 @@ vals.forEach((v) => { // Only testing for 'hostname' validation so ignore connection errors. const dontCare = () => {}; ['', undefined, null].forEach((v) => { - assert.doesNotThrow(() => { - http.request({ hostname: v }).on('error', dontCare).end(); - http.request({ host: v }).on('error', dontCare).end(); - }); + http.request({ hostname: v }).on('error', dontCare).end(); + http.request({ host: v }).on('error', dontCare).end(); }); |