test: use random ports where possible

This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.

PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

1 files changed, 8 insertions, 10 deletions

diff --git a/test/parallel/test-http-default-port.js b/test/parallel/test-http-default-port.js
index 5fe7c00c10..fcea5aac7b 100644
--- a/test/parallel/test-http-default-port.js
+++ b/test/parallel/test-http-default-port.js
@@ -1,8 +1,6 @@
 'use strict';
 const common = require('../common');
 const http = require('http');
-const PORT = common.PORT;
-const SSLPORT = common.PORT + 1;
 const assert = require('assert');
 const hostExpect = 'localhost';
 const fs = require('fs');
@@ -29,18 +27,18 @@ process.on('exit', function() {
   console.log('ok');
 });
 
-http.globalAgent.defaultPort = PORT;
 http.createServer(function(req, res) {
   assert.equal(req.headers.host, hostExpect);
-  assert.equal(req.headers['x-port'], PORT);
+  assert.equal(req.headers['x-port'], this.address().port);
   res.writeHead(200);
   res.end('ok');
   this.close();
-}).listen(PORT, function() {
+}).listen(0, function() {
+  http.globalAgent.defaultPort = this.address().port;
   http.get({
     host: 'localhost',
     headers: {
-      'x-port': PORT
+      'x-port': this.address().port
     }
   }, function(res) {
     gotHttpResp = true;
@@ -49,19 +47,19 @@ http.createServer(function(req, res) {
 });
 
 if (common.hasCrypto) {
-  https.globalAgent.defaultPort = SSLPORT;
   https.createServer(options, function(req, res) {
     assert.equal(req.headers.host, hostExpect);
-    assert.equal(req.headers['x-port'], SSLPORT);
+    assert.equal(req.headers['x-port'], this.address().port);
     res.writeHead(200);
     res.end('ok');
     this.close();
-  }).listen(SSLPORT, function() {
+  }).listen(0, function() {
+    https.globalAgent.defaultPort = this.address().port;
     https.get({
       host: 'localhost',
       rejectUnauthorized: false,
       headers: {
-        'x-port': SSLPORT
+        'x-port': this.address().port
       }
     }, function(res) {
       gotHttpsResp = true;