test: use random ports where possible

This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.

PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

1 files changed, 4 insertions, 4 deletions

diff --git a/test/parallel/test-http-connect.js b/test/parallel/test-http-connect.js
index 43c272d893..b0efca64fa 100644
--- a/test/parallel/test-http-connect.js
+++ b/test/parallel/test-http-connect.js
@@ -1,5 +1,5 @@
 'use strict';
-var common = require('../common');
+require('../common');
 var assert = require('assert');
 var http = require('http');
 
@@ -25,9 +25,9 @@ server.on('connect', function(req, socket, firstBodyChunk) {
     socket.end(data);
   });
 });
-server.listen(common.PORT, function() {
+server.listen(0, function() {
   var req = http.request({
-    port: common.PORT,
+    port: this.address().port,
     method: 'CONNECT',
     path: 'google.com:443'
   }, function(res) {
@@ -44,7 +44,7 @@ server.listen(common.PORT, function() {
     clientGotConnect = true;
 
     // Make sure this request got removed from the pool.
-    var name = 'localhost:' + common.PORT;
+    var name = 'localhost:' + server.address().port;
     assert(!http.globalAgent.sockets.hasOwnProperty(name));
     assert(!http.globalAgent.requests.hasOwnProperty(name));