diff options
| author | Luigi Pinca <luigipinca@gmail.com> | 2018-02-19 15:09:48 +0100 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-02-22 15:51:25 +0000 |
| commit | 2b7f920e26171f05fac437d867a30209f57c6bad (patch) | |
| tree | ba41ecce74ed1e674f7d52ca336a401995de04b1 /test/parallel/test-http-connect.js | |
| parent | ffab6cd5057bce6dbbcbe06b0eaa0f905aa43115 (diff) | |
| download | android-node-v8-2b7f920e26171f05fac437d867a30209f57c6bad.tar.gz android-node-v8-2b7f920e26171f05fac437d867a30209f57c6bad.tar.bz2 android-node-v8-2b7f920e26171f05fac437d867a30209f57c6bad.zip | |
http: remove default 'drain' listener on upgrade
Ensure that the default `'drain'` listener is removed before the
`'connect'` or `'upgrade'` event is emitted.
PR-URL: https://github.com/nodejs/node/pull/18866
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'test/parallel/test-http-connect.js')
| -rw-r--r-- | test/parallel/test-http-connect.js | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/test/parallel/test-http-connect.js b/test/parallel/test-http-connect.js index e7fb116de9..f90d235521 100644 --- a/test/parallel/test-http-connect.js +++ b/test/parallel/test-http-connect.js @@ -74,6 +74,7 @@ server.listen(0, common.mustCall(() => { assert.strictEqual(socket._httpMessage, null); assert.strictEqual(socket.listeners('connect').length, 0); assert.strictEqual(socket.listeners('data').length, 0); + assert.strictEqual(socket.listeners('drain').length, 0); // the stream.Duplex onend listener // allow 0 here, so that i can run the same test on streams1 impl |